From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753583Ab3LCLEx (ORCPT ); Tue, 3 Dec 2013 06:04:53 -0500 Received: from mga02.intel.com ([134.134.136.20]:40294 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753429Ab3LCLEc (ORCPT ); Tue, 3 Dec 2013 06:04:32 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.93,817,1378882800"; d="scan'208";a="445949404" Date: Tue, 3 Dec 2013 13:04:12 +0200 From: Heikki Krogerus To: Alexandre Courbot Cc: Linus Walleij , Mika Westerberg , Andy Shevchenko , Rhyland Klein , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] gpio: better lookup method for platform GPIOs Message-ID: <20131203110412.GC26423@xps8300> References: <1386040811-27946-1-git-send-email-acourbot@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1386040811-27946-1-git-send-email-acourbot@nvidia.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, Dec 03, 2013 at 12:20:11PM +0900, Alexandre Courbot wrote: > Change the format of the platform GPIO lookup tables to make them less > confusing and improve lookup efficiency. > > The previous format was a single linked-list that required to compare > the device name and function ID of every single GPIO defined for each > lookup. Switch that to a list of per-device tables, so that the lookup > can be done in two steps, omitting the GPIOs that are not relevant for a > particular device. > > The matching rules are now defined as follows: > - The device name must match *exactly*, and can be NULL for GPIOs not > assigned to a particular device, > - If the function ID in the lookup table is NULL, the con_id argument of > gpiod_get() will not be used for lookup. However, if it is defined, it > must match exactly. > - The index must always match. > > Signed-off-by: Alexandre Courbot > Acked-by: Mika Westerberg > Reviewed-by: Andy Shevchenko > --- > Changes since v2: > - Removed size member of the gpiod_lookup_table struct (thanks Heikki!) > - Added Andy's reviewed-by > > Documentation/gpio/board.txt | 28 ++++++----- > drivers/gpio/gpiolib.c | 108 +++++++++++++++++++++++-------------------- > include/linux/gpio/driver.h | 21 ++++----- > 3 files changed, 85 insertions(+), 72 deletions(-) Looks good. Thanks Alexandre! -- heikki