From: Tejun Heo <tj@kernel.org>
To: Dave Chinner <david@fromorbit.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, Jens Axboe <axboe@kernel.dk>,
tomaz.solc@tablix.org, aaron.lu@intel.com,
linux-kernel@vger.kernel.org, Oleg Nesterov <oleg@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Fengguang Wu <fengguang.wu@intel.com>
Subject: Re: Writeback threads and freezable
Date: Mon, 16 Dec 2013 07:51:24 -0500 [thread overview]
Message-ID: <20131216125124.GC32509@htj.dyndns.org> (raw)
In-Reply-To: <20131216035652.GY31386@dastard>
On Mon, Dec 16, 2013 at 02:56:52PM +1100, Dave Chinner wrote:
> > What are you suggesting? Implementing separate warm and hot unplug
> > paths? That makes no sense whatsoever. Device hot unplug is just a
> > sub operation of general device unplug which should be able to succeed
> > whether the underlying device is failing IOs or not.
>
> I don't care. Trying to issue IO from an an IO error handling path
> where the device has just been removed is fundamentally broken.
What? Have you even read the original message? IO error handling
path isn't issuing the IO here. The hot unplug operation is
completely asynchronous to the IO path. What's dead locking is not
the filesystem and IO path but device driver layer and hot unplug
path. IOs are not stalled.
> Indeed, what I'm asking for is for a notification so that we can
> *shut the filesystem down* straight away, rather than have to wait
> for an IO error in a critical metadata structure to trigger the
> shutdown for us.
which has exactly zero to do with the issue at hand. Would you please
stop derailing the discussion? Again, IOs are not stalled. That's
not the issue here.
> > > It's simply not a valid thing to do - just how is the filesystem
> > > supposed to sync to a non-existent device?
> >
> > By issuing all IOs and then handling the failures appropriately.
>
> Which bit of "filesystem might deadlock trying to issue IO" didn't
> you understand?
smh, I give up.
--
tejun
next prev parent reply other threads:[~2013-12-16 12:51 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 17:49 Writeback threads and freezable Tejun Heo
2013-12-13 18:52 ` Tejun Heo
2013-12-13 20:40 ` [PATCH] libata, freezer: avoid block device removal while system is frozen Tejun Heo
2013-12-13 22:45 ` Nigel Cunningham
2013-12-13 23:07 ` Tejun Heo
2013-12-13 23:15 ` Nigel Cunningham
2013-12-14 1:55 ` Dave Chinner
2013-12-14 20:31 ` Tejun Heo
2013-12-14 20:36 ` Tejun Heo
2013-12-14 21:21 ` Nigel Cunningham
2013-12-17 2:35 ` Rafael J. Wysocki
2013-12-17 2:34 ` Rafael J. Wysocki
2013-12-17 12:34 ` Tejun Heo
2013-12-18 0:35 ` Rafael J. Wysocki
2013-12-18 11:17 ` Tejun Heo
2013-12-18 21:48 ` Rafael J. Wysocki
2013-12-18 21:39 ` Tejun Heo
2013-12-18 21:41 ` Tejun Heo
2013-12-18 22:04 ` Rafael J. Wysocki
2013-12-19 23:35 ` [PATCH wq/for-3.14 1/2] workqueue: update max_active clamping rules Tejun Heo
2013-12-20 1:26 ` Rafael J. Wysocki
2013-12-19 23:37 ` [PATCH wq/for-3.14 2/2] workqueue: implement @drain for workqueue_set_max_active() Tejun Heo
2013-12-20 1:31 ` Rafael J. Wysocki
2013-12-20 13:32 ` Tejun Heo
2013-12-20 13:56 ` Rafael J. Wysocki
2013-12-20 14:23 ` Tejun Heo
2013-12-16 12:12 ` [PATCH] libata, freezer: avoid block device removal while system is frozen Ming Lei
2013-12-16 12:45 ` Tejun Heo
2013-12-16 13:24 ` Ming Lei
2013-12-16 16:05 ` Tejun Heo
2013-12-17 2:38 ` Rafael J. Wysocki
2013-12-17 12:36 ` Tejun Heo
2013-12-18 0:23 ` Rafael J. Wysocki
2013-12-17 12:50 ` [PATCH v2] " Tejun Heo
2013-12-18 1:04 ` Rafael J. Wysocki
2013-12-18 11:08 ` Tejun Heo
2013-12-18 12:07 ` [PATCH v3] " Tejun Heo
2013-12-18 22:08 ` Rafael J. Wysocki
2013-12-19 17:24 ` Tejun Heo
2013-12-19 18:54 ` [PATCH v4] " Tejun Heo
2013-12-14 1:53 ` Writeback threads and freezable Dave Chinner
2013-12-14 17:30 ` Greg Kroah-Hartman
2013-12-14 20:23 ` Tejun Heo
2013-12-16 3:56 ` Dave Chinner
2013-12-16 12:51 ` Tejun Heo [this message]
2013-12-16 12:56 ` Tejun Heo
2013-12-18 0:35 ` Dave Chinner
2013-12-18 11:43 ` Tejun Heo
2013-12-18 22:14 ` Rafael J. Wysocki
2013-12-19 4:08 ` Dave Chinner
2013-12-19 16:24 ` Tejun Heo
2013-12-20 0:51 ` Dave Chinner
2013-12-20 14:51 ` Tejun Heo
2013-12-20 14:00 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131216125124.GC32509@htj.dyndns.org \
--to=tj@kernel.org \
--cc=aaron.lu@intel.com \
--cc=axboe@kernel.dk \
--cc=david@fromorbit.com \
--cc=fengguang.wu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=rjw@sisk.pl \
--cc=tomaz.solc@tablix.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).