From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752215Ab3LRLlX (ORCPT ); Wed, 18 Dec 2013 06:41:23 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:44821 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751267Ab3LRLlV (ORCPT ); Wed, 18 Dec 2013 06:41:21 -0500 X-Sasl-enc: h+KXwfUrRTuTbcF/97rUGrPrKNHgmvgZvajSi74MsW7g 1387366880 Date: Wed, 18 Dec 2013 09:41:17 -0200 From: Henrique de Moraes Holschuh To: Lv Zheng Cc: "Rafael J. Wysocki" , Len Brown , Lv Zheng , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Henrique de Moraes Holschuh , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org Subject: Re: [RFC PATCH 15/15] ACPI/thinkpad: Fix wrong inclusion in Thinkpad ACPI users. Message-ID: <20131218114117.GB29631@khazad-dum.debian.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-GPG-Fingerprint1: 4096R/39CB4807 C467 A717 507B BAFE D3C1 6092 0BD9 E811 39CB 4807 X-GPG-Fingerprint2: 1024D/1CDB0FE3 5422 5C61 F6B7 06FB 7E04 3738 EE25 DE3F 1CDB 0FE3 User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 Dec 2013, Lv Zheng wrote: > CONFIG_ACPI dependent code should include instead of > directly including . This patch cleans up such wrong > inclusions for Thinkpad ACPI users. ... > drivers/platform/x86/thinkpad_acpi.c | 1 - > include/linux/thinkpad_acpi.h | 2 ++ > sound/pci/hda/patch_conexant.c | 1 - > sound/pci/hda/patch_realtek.c | 1 - I'd prefer if you left the include outside of thinkpad_acpi.h, and just fix the include in the two ALSA users. We might add some extra stuff to thinkpad_acpi.h someday, and not everything thinkpad_acpi does that might be useful to export to other areas of the kernel would require acpi.h. Looking at patch_conexant and patch_realtek, it might be better to actually move the "am I running on a thinkpad" stuff they use acpi.h for into thinkpad_acpi, and provide a prototype for that in thinkpad_acpi.h. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh