* linux-next: build failures after merge of the keys tree
@ 2019-12-12 0:59 Stephen Rothwell
2020-01-09 2:22 ` Stephen Rothwell
2020-01-16 20:47 ` David Howells
0 siblings, 2 replies; 4+ messages in thread
From: Stephen Rothwell @ 2019-12-12 0:59 UTC (permalink / raw)
To: David Howells; +Cc: Linux Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 5651 bytes --]
Hi all,
After merging the keys tree, today's linux-next build (x86_64
allmodconfig) failed like this:
In file included from include/linux/keyctl.h:11,
from include/linux/key.h:35,
from include/linux/key-type.h:11,
from fs/crypto/keyring.c:22:
fs/crypto/keyring.c: In function 'allocate_filesystem_keyring':
include/uapi/linux/keyctl.h:52:24: warning: passing argument 5 of 'keyring_alloc' makes pointer from integer without a cast [-Wint-conversion]
52 | #define KEY_POS_SEARCH 0x08000000 /* possessor can find a key in search / search a keyring */
| ^
| |
| int
fs/crypto/keyring.c:208:21: note: in expansion of macro 'KEY_POS_SEARCH'
208 | current_cred(), KEY_POS_SEARCH |
| ^~~~~~~~~~~~~~
In file included from include/linux/key-type.h:11,
from fs/crypto/keyring.c:22:
include/linux/key.h:390:20: note: expected 'struct key_acl *' but argument is of type 'int'
390 | extern struct key *keyring_alloc(const char *description, kuid_t uid, kgid_t gid,
| ^~~~~~~~~~~~~
In file included from include/linux/keyctl.h:11,
from include/linux/key.h:35,
from include/linux/key-type.h:11,
from fs/crypto/keyring.c:22:
fs/crypto/keyring.c: In function 'allocate_master_key_users_keyring':
include/uapi/linux/keyctl.h:52:24: warning: passing argument 5 of 'keyring_alloc' makes pointer from integer without a cast [-Wint-conversion]
52 | #define KEY_POS_SEARCH 0x08000000 /* possessor can find a key in search / search a keyring */
| ^
| |
| int
fs/crypto/keyring.c:252:21: note: in expansion of macro 'KEY_POS_SEARCH'
252 | current_cred(), KEY_POS_SEARCH |
| ^~~~~~~~~~~~~~
In file included from include/linux/key-type.h:11,
from fs/crypto/keyring.c:22:
include/linux/key.h:390:20: note: expected 'struct key_acl *' but argument is of type 'int'
390 | extern struct key *keyring_alloc(const char *description, kuid_t uid, kgid_t gid,
| ^~~~~~~~~~~~~
In file included from include/linux/keyctl.h:11,
from include/linux/key.h:35,
from include/linux/key-type.h:11,
from fs/crypto/keyring.c:22:
fs/crypto/keyring.c: In function 'add_master_key_user':
include/uapi/linux/keyctl.h:52:24: warning: passing argument 6 of 'key_alloc' makes pointer from integer without a cast [-Wint-conversion]
52 | #define KEY_POS_SEARCH 0x08000000 /* possessor can find a key in search / search a keyring */
| ^
| |
| int
fs/crypto/keyring.c:290:8: note: in expansion of macro 'KEY_POS_SEARCH'
290 | KEY_POS_SEARCH | KEY_USR_VIEW, 0, NULL);
| ^~~~~~~~~~~~~~
In file included from include/linux/key-type.h:11,
from fs/crypto/keyring.c:22:
include/linux/key.h:256:20: note: expected 'struct key_acl *' but argument is of type 'int'
256 | extern struct key *key_alloc(struct key_type *type,
| ^~~~~~~~~
In file included from include/linux/keyctl.h:11,
from include/linux/key.h:35,
from include/linux/key-type.h:11,
from fs/crypto/keyring.c:22:
fs/crypto/keyring.c: In function 'add_new_master_key':
include/uapi/linux/keyctl.h:52:24: warning: passing argument 6 of 'key_alloc' makes pointer from integer without a cast [-Wint-conversion]
52 | #define KEY_POS_SEARCH 0x08000000 /* possessor can find a key in search / search a keyring */
| ^
| |
| int
fs/crypto/keyring.c:362:4: note: in expansion of macro 'KEY_POS_SEARCH'
362 | KEY_POS_SEARCH | KEY_USR_SEARCH | KEY_USR_VIEW,
| ^~~~~~~~~~~~~~
In file included from include/linux/key-type.h:11,
from fs/crypto/keyring.c:22:
include/linux/key.h:256:20: note: expected 'struct key_acl *' but argument is of type 'int'
256 | extern struct key *key_alloc(struct key_type *type,
| ^~~~~~~~~
fs/crypto/keysetup_v1.c: In function 'find_and_lock_process_key':
fs/crypto/keysetup_v1.c:107:8: error: too few arguments to function 'request_key'
107 | key = request_key(&key_type_logon, description, NULL);
| ^~~~~~~~~~~
In file included from include/keys/user-type.h:11,
from fs/crypto/keysetup_v1.c:25:
include/linux/key.h:321:27: note: declared here
321 | static inline struct key *request_key(struct key_type *type,
| ^~~~~~~~~~~
drivers/md/dm-verity-verify-sig.c: In function 'verity_verify_get_sig_from_key':
drivers/md/dm-verity-verify-sig.c:38:8: error: too few arguments to function 'request_key'
38 | key = request_key(&key_type_user,
| ^~~~~~~~~~~
In file included from include/keys/user-type.h:11,
from drivers/md/dm-verity-verify-sig.c:10:
include/linux/key.h:321:27: note: declared here
321 | static inline struct key *request_key(struct key_type *type,
| ^~~~~~~~~~~
Caused by commit
068df091816a ("keys: Replace uid/gid/perm permissions checking with an ACL")
I have used the keys tree from next-20191211 for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: build failures after merge of the keys tree
2019-12-12 0:59 linux-next: build failures after merge of the keys tree Stephen Rothwell
@ 2020-01-09 2:22 ` Stephen Rothwell
2020-01-16 20:47 ` David Howells
1 sibling, 0 replies; 4+ messages in thread
From: Stephen Rothwell @ 2020-01-09 2:22 UTC (permalink / raw)
To: David Howells; +Cc: Linux Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 459 bytes --]
Hi David,
On Thu, 12 Dec 2019 11:59:01 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the keys tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
....
> Caused by commit
>
> 068df091816a ("keys: Replace uid/gid/perm permissions checking with an ACL")
>
> I have used the keys tree from next-20191211 for today.
Any ETA on when this tree will be updated?
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: build failures after merge of the keys tree
2019-12-12 0:59 linux-next: build failures after merge of the keys tree Stephen Rothwell
2020-01-09 2:22 ` Stephen Rothwell
@ 2020-01-16 20:47 ` David Howells
2020-01-16 21:28 ` Stephen Rothwell
1 sibling, 1 reply; 4+ messages in thread
From: David Howells @ 2020-01-16 20:47 UTC (permalink / raw)
To: Stephen Rothwell
Cc: dhowells, Linux Next Mailing List, Linux Kernel Mailing List
Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Any ETA on when this tree will be updated?
That should be fixed now.
David
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: build failures after merge of the keys tree
2020-01-16 20:47 ` David Howells
@ 2020-01-16 21:28 ` Stephen Rothwell
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Rothwell @ 2020-01-16 21:28 UTC (permalink / raw)
To: David Howells; +Cc: Linux Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 288 bytes --]
Hi David,
On Thu, 16 Jan 2020 20:47:00 +0000 David Howells <dhowells@redhat.com> wrote:
>
> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> > Any ETA on when this tree will be updated?
>
> That should be fixed now.
Excellent, thanks.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-16 21:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-12 0:59 linux-next: build failures after merge of the keys tree Stephen Rothwell
2020-01-09 2:22 ` Stephen Rothwell
2020-01-16 20:47 ` David Howells
2020-01-16 21:28 ` Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).