From: Mark Brown <broonie@kernel.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>, Rob Landley <rob@landley.net>,
Sangbeom Kim <sbkim73@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
Grant Likely <grant.likely@linaro.org>,
Sachin Kamat <sachin.kamat@linaro.org>,
Amit Daniel Kachhap <amit.daniel@samsung.com>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH v2 2/2] regulator: s5m8767: Document new bindings for Buck9 GPIO control
Date: Wed, 22 Jan 2014 19:49:27 +0000 [thread overview]
Message-ID: <20140122194927.GZ17314@sirena.org.uk> (raw)
In-Reply-To: <1390406848-20964-3-git-send-email-k.kozlowski@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 711 bytes --]
On Wed, Jan 22, 2014 at 05:07:28PM +0100, Krzysztof Kozlowski wrote:
> Add documentation for new bindings for controlling (enable/disable) the
> Buck9 Converter by GPIO (BUCK9EN).
Your CC list for this is *very* large...
> + - s5m8767,pmic-ext-control-enable: regulator can be enabled/disabled
> + by GPIO (valid only for buck9).
> + - s5m8767,pmic-ext-control-gpio: GPIO specifier for one GPIO
> + controlling this regulator (valid only for buck9).
> + This property is required when 's5m8767,pmic-ext-control-enable' is specified.
In what situation might the GPIO be present but not usable - can't we
just use the presence of the GPIO property? Also GPIO properties are
supposed to be always "-gpios".
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-01-22 19:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-22 16:07 [PATCH v2 0/2] regulator: s5m8767: Use GPIO for controlling Buck9/eMMC Krzysztof Kozlowski
2014-01-22 16:07 ` [PATCH v2 1/2] " Krzysztof Kozlowski
2014-01-22 16:07 ` [PATCH v2 2/2] regulator: s5m8767: Document new bindings for Buck9 GPIO control Krzysztof Kozlowski
2014-01-22 19:49 ` Mark Brown [this message]
2014-01-23 7:37 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140122194927.GZ17314@sirena.org.uk \
--to=broonie@kernel.org \
--cc=amit.daniel@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=k.kozlowski@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=sameo@linux.intel.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).