From: Tejun Heo <tj@kernel.org>
To: Yogesh Gaur <yogeshgaur.83@gmail.com>
Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: Suspected Copy Paste error in rtnl_bridge_notify
Date: Fri, 31 Jan 2014 06:47:12 -0500 [thread overview]
Message-ID: <20140131114712.GB26148@htj.dyndns.org> (raw)
In-Reply-To: <CAG6enPyV9bvYSwDrMp6X1LY6PXrmrP5MtjNk0N+7qs1LDY5pRg@mail.gmail.com>
Hey,
Seems suspicious but I don't know the code at all. cc'ing David and
netdev and quoting the whole body for them.
Thanks.
On Fri, Jan 31, 2014 at 11:32:55AM +0530, Yogesh Gaur wrote:
> Hello All,
>
> I want to clarify about following code-snippet from
> file: "net/core/rtnetlink.c"
> func: rtnl_bridge_notify
>
> ----------------------------------------------------------------------------
> | if ((!flags || (flags & BRIDGE_FLAGS_MASTER)) && |
> | br_dev && br_dev->netdev_ops->ndo_bridge_getlink) {
> |
> | err = br_dev->netdev_ops->ndo_bridge_getlink(skb, 0, 0, dev, 0);
> |
> | if (err < 0)
> |
> | goto errout;
> |
> | }
> |
> |
> |
> | if ((flags & BRIDGE_FLAGS_SELF) &&
> |
> | dev->netdev_ops->ndo_bridge_getlink) {
> |
> | err = dev->netdev_ops->ndo_bridge_getlink(skb, 0, 0, dev, 0);
> |
> | if (err < 0)
> |
> | goto errout;
> |
> ----------------------------------------------------------------------------
>
> In above code isn't code line:
> err = br_dev->netdev_ops->ndo_bridge_getlink(skb, 0, 0, dev, 0);
> should be
> err = br_dev->netdev_ops->ndo_bridge_getlink(skb, 0, 0, br_dev, 0);
>
> If this needs to be changed then please review attached patch adding this
> change.
--
tejun
next parent reply other threads:[~2014-01-31 11:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAG6enPwAfm8YDrGmEEitv_fHeF5rVVN2nXujh=u4kVy0sKx4ag@mail.gmail.com>
[not found] ` <CAG6enPyV9bvYSwDrMp6X1LY6PXrmrP5MtjNk0N+7qs1LDY5pRg@mail.gmail.com>
2014-01-31 11:47 ` Tejun Heo [this message]
2014-02-07 3:45 ` Suspected Copy Paste error in rtnl_bridge_notify David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140131114712.GB26148@htj.dyndns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=yogeshgaur.83@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).