From: Mark Brown <broonie@kernel.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Sangbeom Kim <sbkim73@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: s2mps11: Fix NULL pointer of_node value when using platform data
Date: Fri, 31 Jan 2014 16:53:50 +0000 [thread overview]
Message-ID: <20140131165350.GR22609@sirena.org.uk> (raw)
In-Reply-To: <1391089879-7342-1-git-send-email-k.kozlowski@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 418 bytes --]
On Thu, Jan 30, 2014 at 02:51:19PM +0100, Krzysztof Kozlowski wrote:
> When platform_data is used for regulator (of_node of sec-core MFD device
> is NULL) the config.of_node for regulator is not initialized. This NULL
> value of config.of_node is later stored during regulator_register().
> Thus any call by regulator consumers to of_get_regulator() will fail on
> of_parse_phandle() returning NULL.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2014-01-31 16:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 13:51 [PATCH] regulator: s2mps11: Fix NULL pointer of_node value when using platform data Krzysztof Kozlowski
2014-01-31 16:53 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140131165350.GR22609@sirena.org.uk \
--to=broonie@kernel.org \
--cc=k.kozlowski@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).