linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Capella <sebastian.capella@linaro.org>
To: Pavel Machek <pavel@ucw.cz>, "David Rientjes" <rientjes@google.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linux-pm@vger.kernel.org, linaro-kernel@lists.linaro.org,
	patches@linaro.org, "Andrew Morton" <akpm@linux-foundation.org>,
	"Michel Lespinasse" <walken@google.com>,
	"Shaohua Li" <shli@kernel.org>,
	"Jerome Marchand" <jmarchan@redhat.com>,
	"Mikulas Patocka" <mpatocka@redhat.com>,
	"Joonsoo Kim" <iamjoonsoo.kim@lge.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH v4 1/2] mm: add kstrimdup function
Date: Fri, 31 Jan 2014 12:00:29 -0800	[thread overview]
Message-ID: <20140131200029.13265.72190@capellas-linux> (raw)
In-Reply-To: <20140131122421.GA3305@amd.pavel.ucw.cz>

Quoting Pavel Machek (2014-01-31 04:24:21)
> Well, your /sys/power/resume patch would be nice cleanup, but it
> changs behaviour, too... which is unnice. Stripping trailing "\n" is
> probably neccessary, because we did it before. (It probably was a
> mistake). But kernel is not right place to second-guess what the user
> meant. Just return -EINVAL. This is kernel ABI, after all, not user
> facing shell.

Thanks guys!  I hadn't thought of these cases.

It sounds like we're really back to stripping one trailing \n to match
the sysfs behavior to which people have become accustomed, and leave
the rest of the string untouched in case the whitespace is intentional.

Should a user intentionally have input ending in a newline, then they
should add an additional newline, expecting it to be stripped, but
otherwise, their string is taken as entered.

Does this sound right?

Meanwhile, I'll try a test to see how name_to_dev_t handles files with
spaces in them.

Thanks,

Sebastian


  reply	other threads:[~2014-01-31 20:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-29 23:48 [PATCH v4 0/2] PM / Hibernate: sysfs resume Sebastian Capella
2014-01-29 23:48 ` [PATCH v4 1/2] mm: add kstrimdup function Sebastian Capella
2014-01-30  0:58   ` Mikulas Patocka
2014-01-30  1:02     ` Mikulas Patocka
2014-01-30  1:24     ` Joe Perches
2014-01-30  3:41       ` Sebastian Capella
2014-01-30  3:50         ` Joe Perches
2014-01-31 10:32   ` Pavel Machek
2014-01-31 10:46     ` David Rientjes
2014-01-31 12:24       ` Pavel Machek
2014-01-31 20:00         ` Sebastian Capella [this message]
2014-01-29 23:48 ` [PATCH v4 2/2] PM / Hibernate: use name_to_dev_t to parse resume Sebastian Capella
2014-01-30 18:01   ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140131200029.13265.72190@capellas-linux \
    --to=sebastian.capella@linaro.org \
    --cc=akpm@linux-foundation.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=jmarchan@redhat.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mpatocka@redhat.com \
    --cc=patches@linaro.org \
    --cc=pavel@ucw.cz \
    --cc=rientjes@google.com \
    --cc=rjw@rjwysocki.net \
    --cc=shli@kernel.org \
    --cc=walken@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).