From: Al Viro <viro@ZenIV.linux.org.uk>
To: Jeff Layton <jlayton@redhat.com>
Cc: Oleg Drokin <green@linuxhacker.ru>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] Fix mountpoint reference leakage in linkat
Date: Fri, 31 Jan 2014 22:30:14 +0000 [thread overview]
Message-ID: <20140131223013.GP10323@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20140131163231.2585a08d@tlielax.poochiereds.net>
On Fri, Jan 31, 2014 at 04:32:31PM -0500, Jeff Layton wrote:
> done_path_create(&new_path, new_dentry);
> + path_put(&old_path);
... and the filesystem in question isn't pinned anymore, so it can be
unmounted, except that
> if (delegated_inode) {
> error = break_deleg_wait(&delegated_inode);
this does an iput() on delegated_inode. And umount really doesn't
like finding pinned inodes. Sorry, no go.
I'm going with Oleg's patch with second path_put() added.
next prev parent reply other threads:[~2014-01-31 22:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-31 20:41 [PATCH] Fix mountpoint reference leakage in linkat Oleg Drokin
2014-01-31 20:52 ` Jeff Layton
2014-01-31 21:03 ` Al Viro
2014-01-31 21:13 ` Oleg Drokin
2014-01-31 21:32 ` Jeff Layton
2014-01-31 21:50 ` Oleg Drokin
2014-01-31 22:30 ` Al Viro [this message]
2014-01-31 22:34 ` [PATCH v2] vfs: " Oleg Drokin
2014-01-31 23:11 ` [PATCH] " Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140131223013.GP10323@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=green@linuxhacker.ru \
--cc=jlayton@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).