From: Mika Westerberg <email@example.com> To: "Rafael J. Wysocki" <firstname.lastname@example.org> Cc: Yinghai Lu <email@example.com>, Bjorn Helgaas <firstname.lastname@example.org>, "email@example.com" <firstname.lastname@example.org>, "Rafael J. Wysocki" <email@example.com>, Linus Torvalds <firstname.lastname@example.org>, Linux Kernel Mailing List <email@example.com> Subject: Re: [PATCH] Revert "PCI: Remove from bus_list and release resources in pci_release_dev()" Date: Sat, 1 Feb 2014 20:48:22 +0200 [thread overview] Message-ID: <20140201184822.GO18029@intel.com> (raw) In-Reply-To: <14676899.LOmsodapl3@vostro.rjw.lan> On Sat, Feb 01, 2014 at 03:38:29PM +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <firstname.lastname@example.org> > Subject: Revert "PCI: Remove from bus_list and release resources in pci_release_dev()" > > Revert commit ef83b0781a73 "PCI: Remove from bus_list and release > resources in pci_release_dev()" that made some nasty race conditions > become possible. For example, if a Thunderbolt link is unplugged > and then replugged immediately, the pci_release_dev() resulting from > the hot-remove code path may be racing with the hot-add code path > which after that commit causes various kinds of breakage to happen > (up to and including a hard crash of the whole system). > > Moreover, the problem that commit ef83b0781a73 attempted to address > cannot happen any more after commit 8a4c5c329de7 "PCI: Check parent > kobject in pci_destroy_dev()", because pci_destroy_dev() will now > return immediately if it has already been executed for the given > device. > > Note, however, that the invocation of msi_remove_pci_irq_vectors() > removed by commit ef83b0781a73 from pci_free_resources() along with > the other changes made by it is not added back because of subsequent > code changes depending on that modification. > > Fixes: ef83b0781a73 (PCI: Remove from bus_list and release resources in pci_release_dev()) > Reported-by: Mika Westerberg <email@example.com> > Signed-off-by: Rafael J. Wysocki <firstname.lastname@example.org> Thanks, that fixes the problem I'm seeing.
prev parent reply other threads:[~2014-02-01 18:41 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20140130131236.GW18029@intel.com> 2014-01-31 23:34 ` Rafael J. Wysocki 2014-02-01 1:56 ` Yinghai Lu 2014-02-01 14:38 ` Rafael J. Wysocki 2014-02-01 18:23 ` Linus Torvalds 2014-02-01 18:48 ` Mika Westerberg [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20140201184822.GO18029@intel.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] Revert "PCI: Remove from bus_list and release resources in pci_release_dev()"' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).