From: Mark Brown <broonie@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Shimoda, Yoshihiro" <yoshihiro.shimoda.uh@renesas.com>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-spi@vger.kernel.org, SH-Linux <linux-sh@vger.kernel.org>,
devicetree@vger.kernel.org,
Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] spi: rspi: fix build error when CONFIG_OF is not set
Date: Mon, 3 Feb 2014 15:17:21 +0000 [thread overview]
Message-ID: <20140203151721.GA22609@sirena.org.uk> (raw)
In-Reply-To: <alpine.DEB.2.02.1402030939520.25794@ayla.of.borg>
[-- Attachment #1: Type: text/plain, Size: 696 bytes --]
On Mon, Feb 03, 2014 at 09:47:25AM +0100, Geert Uytterhoeven wrote:
> Thanks, obviously I missed that of_match_device() still uses the ID table
> parameter if CONFIG_OF=n :-(
> Below I have two alternative solutions:
> 1. Uses rspi_of_match() to nullify the ID table pointer, like is done in
> the platform_driver structure,
> 2. Fixes it at the OF subsystem level, by nullifying the ID table pointer
> inside of_match_device().
> If 2 is accepted, drivers don't have to care about this anymore.
I think if we can fix it at the subsystem level that's clearly nicer
since it means nothing else will run into the same issue. Your patch
looks OK to me, I'd suggest submitting it.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-02-03 15:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <52EEF452.4060205@renesas.com>
2014-02-03 8:47 ` [PATCH] spi: rspi: fix build error when CONFIG_OF is not set Geert Uytterhoeven
2014-02-03 15:17 ` Mark Brown [this message]
2014-02-03 21:45 ` Rob Herring
2014-02-04 5:56 ` Shimoda, Yoshihiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140203151721.GA22609@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).