From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752737AbaBSLlk (ORCPT ); Wed, 19 Feb 2014 06:41:40 -0500 Received: from mail-wg0-f51.google.com ([74.125.82.51]:59581 "EHLO mail-wg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751799AbaBSLlj (ORCPT ); Wed, 19 Feb 2014 06:41:39 -0500 Date: Wed, 19 Feb 2014 11:41:32 +0000 From: Lee Jones To: Michal Simek Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Michal Simek , Samuel Ortiz , linux-kernel@vger.kernel.org, broonie@kernel.org Subject: Re: [RFC PATCH v2 1/2] mfd: syscon: Support early initialization Message-ID: <20140219114132.GC10504@lee--X1> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org FAO Arnd, Mark, > Some platforms need to get system controller > ready as soon as possible. > The patch provides early_syscon_initialization > which create early mapping for all syscon compatible > devices in early_syscon_probe. > Regmap is get via syscon_early_regmap_lookup_by_phandle() > > Regular device probes attach device to regmap > via regmap_attach_dev(). > > For early syscon initialization is necessary to extend > struct syscon and provide remove function > which unmap all early init structures. > > Signed-off-by: Michal Simek > --- > > Changes in v2: > - Fix bad logic in early_syscon_probe > - Fix compilation failure for x86_64 reported by zero day testing system > - Regmap change available here > git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git tags/nodev > > drivers/mfd/syscon.c | 128 +++++++++++++++++++++++++++++++++++++++------ > include/linux/mfd/syscon.h | 11 ++++ > 2 files changed, 122 insertions(+), 17 deletions(-) I have the same reservations as last time: http://archive.arm.linux.org.uk/lurker/message/20140212.095424.96cb7281.html I believe you were waiting for Arnd and/or Mark to comment. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog