From: Peter Zijlstra <peterz@infradead.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: Vince Weaver <vincent.weaver@maine.edu>,
Dave Jones <davej@redhat.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>, Paul Mackerras <paulus@samba.org>,
Steven Rostedt <rostedt@goodmis.org>,
Jiri Olsa <jolsa@redhat.com>
Subject: Re: x86_pmu_start WARN_ON.
Date: Thu, 20 Feb 2014 19:15:38 +0100 [thread overview]
Message-ID: <20140220181538.GK9987@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <87mwhld72w.fsf@tassilo.jf.intel.com>
On Thu, Feb 20, 2014 at 09:31:19AM -0800, Andi Kleen wrote:
> Peter Zijlstra <peterz@infradead.org> writes:
> >
> > It will; trace_printk() works without -pg, I think you didn't read the
> > instructions very well.
>
> Ok, you enable and disable it again. I won't guess why you do that.
To grow the trace buffers; it starts with just a few pages per cpu; once
you switch to an actual tracer it allocates a sensible amount.
You can grow it with another interface; but then I'd have to like
remember what that was and how big the normal buffers are. Simply
toggling between tracers is far easier.
> > And there's a very good reason not to apply your patch; you can route
> > the function tracer into perf, guess what happens when perf calls the
> > function tracer again :-)
>
> How?
I think by using the /debug/tracing/events/ftrace/function event, but
I'm not actually sure, I've never used it nor did I write the code to do
it. Jolsa did all that IIRC.
All I know is that we had some 'fun' bugs around there sometime back.
next prev parent reply other threads:[~2014-02-20 18:15 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 19:02 x86_pmu_start WARN_ON Dave Jones
2014-02-10 21:26 ` Vince Weaver
2014-02-11 13:29 ` Peter Zijlstra
2014-02-12 21:04 ` Vince Weaver
2014-02-13 14:11 ` Vince Weaver
2014-02-13 17:35 ` Vince Weaver
2014-02-13 22:13 ` Vince Weaver
2014-02-17 15:28 ` Peter Zijlstra
2014-02-18 18:30 ` Vince Weaver
2014-02-18 22:20 ` Vince Weaver
2014-02-19 10:19 ` Peter Zijlstra
2014-02-19 22:34 ` Vince Weaver
2014-02-20 10:08 ` Peter Zijlstra
2014-02-20 15:47 ` Andi Kleen
2014-02-20 15:54 ` Peter Zijlstra
2014-02-20 17:31 ` Andi Kleen
2014-02-20 18:15 ` Peter Zijlstra [this message]
2014-02-20 18:23 ` Andi Kleen
2014-02-20 19:04 ` Steven Rostedt
2014-02-20 16:26 ` Steven Rostedt
2014-02-20 17:00 ` Peter Zijlstra
2014-02-20 17:43 ` Steven Rostedt
2014-02-20 17:46 ` Steven Rostedt
2014-02-20 18:18 ` Peter Zijlstra
2014-02-20 18:03 ` Vince Weaver
2014-02-20 18:23 ` Peter Zijlstra
2014-02-20 18:54 ` Vince Weaver
2014-02-20 19:21 ` Vince Weaver
2014-02-20 19:46 ` Vince Weaver
2014-02-21 14:37 ` Vince Weaver
2014-02-21 15:03 ` Peter Zijlstra
2014-02-21 20:18 ` Vince Weaver
2014-02-24 11:28 ` Peter Zijlstra
2014-02-26 5:59 ` Vince Weaver
2014-02-27 13:32 ` [tip:perf/core] perf/x86: Fix event scheduling tip-bot for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140220181538.GK9987@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=andi@firstfloor.org \
--cc=davej@redhat.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
--cc=vincent.weaver@maine.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).