From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752595AbaBYK5G (ORCPT ); Tue, 25 Feb 2014 05:57:06 -0500 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:57435 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752227AbaBYK46 (ORCPT ); Tue, 25 Feb 2014 05:56:58 -0500 Date: Tue, 25 Feb 2014 10:55:53 +0000 From: Will Deacon To: Pavel Machek Cc: Ivaylo Dimitrov , LKML , "linux@arm.linux.org.uk" , "linux-arm-kernel@lists.infradead.org" , Sebastian Reichel , Pali =?iso-8859-1?Q?Roh=E1r?= , "kvalo@qca.qualcomm.com" , "linville@tuxdriver.com" Subject: Re: [BISECTED] ssh - Received disconnect from x.x.x.x: 2: Bad packet length 3149594624 Message-ID: <20140225105552.GA22279@mudshark.cambridge.arm.com> References: <52FD08D1.3030405@gmail.com> <20140213182105.GN13576@mudshark.cambridge.arm.com> <52FD1243.9040706@gmail.com> <20140213192909.GO13576@mudshark.cambridge.arm.com> <52FE407C.3080002@gmail.com> <20140214162458.GF21986@mudshark.cambridge.arm.com> <52FE4E3F.6020407@gmail.com> <530A46BF.4000107@gmail.com> <20140225104444.GA5563@amd.pavel.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140225104444.GA5563@amd.pavel.ucw.cz> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 25, 2014 at 10:44:44AM +0000, Pavel Machek wrote: > > >>You could try putting back the UNALIGNED_ACCESS in net/mac80211/rx.c and > > >>commenting out the skb->len = desc->length - PLCP_HEADER_LENGTH; line > > >>above. > > > > > >This seems to fix the issue too, but I am afraid there is more to be > > >done, as I see > > > > > >Feb 14 18:33:46 Nokia-N900 kernel: [ 88.599853] wlan0: authenticate > > >with 00:23:cd:17:86:d0 > > >Feb 14 18:33:46 Nokia-N900 kernel: [ 88.781860] wlan0: send auth to > > >00:23:cd:17:86:d0 (try 1/3) > > >Feb 14 18:33:46 Nokia-N900 kernel: [ 88.799804] wlan0: authenticated > > >Feb 14 18:33:46 Nokia-N900 kernel: [ 88.806243] wlan0: associating > > >with AP with corrupt probe response > > >Feb 14 18:33:46 Nokia-N900 kernel: [ 88.814544] wlan0: associate with > > >00:23:cd:17:86:d0 (try 1/3) > > >Feb 14 18:33:46 Nokia-N900 kernel: [ 88.826416] wlan0: RX AssocResp > > >from 00:23:cd:17:86:d0 (capab=0x431 status=0 aid=2) > > > > > >spit in dmesg log. AFAIR this is the first time I see "associating with > > >AP with corrupt probe response" in dmesg, no matter of the kernel > > >version. Despite of that error message, wlan seems to work as it should, > > >so far. I guess we need the driver's author saying on the issue. > > > > ping? > > If Will does not respond, we should simply revert > dce5c9e35bc4085bd33eccdb8c9ec5a643507a14 . Regressions are not > acceptable. Seriously Pavel, give me a break. I already responded pretty quickly to this bug report, took a look at where the issue could be and proposed a fix (which Ivaylo tested successfully). Now, wireless drivers are *waay* outside my area of expertise, so I added some other folks to CC in the hope that they could help turn my fix into something upstreamable. Meanwhile, Ivaylo looks like he has something better than what I came up with already. If you care about this driver, why don't you help us fix it rather than making unhelpful suggestions from the sidelines? Will