From: Mark Brown <broonie@kernel.org>
To: Markus Pargmann <mpa@pengutronix.de>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de
Subject: Re: [PATCH 2/2] regulator: core: Error on not always_on dummy regulators
Date: Tue, 25 Feb 2014 21:26:44 +0900 [thread overview]
Message-ID: <20140225122644.GC25940@sirena.org.uk> (raw)
In-Reply-To: <1393322627-26543-3-git-send-email-mpa@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 580 bytes --]
On Tue, Feb 25, 2014 at 11:03:47AM +0100, Markus Pargmann wrote:
> It does not make sense to have dummy/fixed regulators that are not
> always_on. This patch adds a check in the set_machine_constraints
> function for this case and returns -EINVAL if such a regulator is
> registered.
Such a regulator isn't going to be useful in a system but that doesn't
mean that they shouldn't be registerable since that allows people to
look at their state. For example a device might have some GPIO managed
regulators where the GPIO is tied low if the regulator isn't in use in
the system.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2014-02-25 12:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 10:03 [PATCH 0/2] regulator: core: always_on fixups Markus Pargmann
2014-02-25 10:03 ` [PATCH 1/2] regulator: dummy: Should be always-on Markus Pargmann
2014-02-25 23:50 ` Mark Brown
2014-02-25 10:03 ` [PATCH 2/2] regulator: core: Error on not always_on dummy regulators Markus Pargmann
2014-02-25 12:26 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140225122644.GC25940@sirena.org.uk \
--to=broonie@kernel.org \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpa@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).