linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Lee Jones <lee.jones@linaro.org>
Subject: Re: linux-next: build failure after merge of the libata tree
Date: Wed, 26 Feb 2014 08:49:15 -0500	[thread overview]
Message-ID: <20140226134915.GB17302@htj.dyndns.org> (raw)
In-Reply-To: <20140226135521.047c301755d2bb44401e3ac6@canb.auug.org.au>

On Wed, Feb 26, 2014 at 01:55:21PM +1100, Stephen Rothwell wrote:
> Hi Tejun,
> 
> After merging the libata tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/ata/ahci_st.c: In function 'st_ahci_probe':
> drivers/ata/ahci_st.c:159:8: error: implicit declaration of function 'ahci_platform_put_resources' [-Werror=implicit-function-declaration]
>         ahci_platform_put_resources(&pdev->dev, hpriv);
>         ^
> 
> Caused by commit 0d8d213703ff ("ahci: st: Add support for ST's SATA
> IP").  That function is defined as "static" in another file ...
> 
> I have used the version of the libata tree from next-20140225 for today.

Right, that patch was against the previous version which didn't use
devres.  The put_resources calls are no longer necessary.  Will revert
the patch for now.

Thanks.

-- 
tejun

  reply	other threads:[~2014-02-26 13:49 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-26  2:55 linux-next: build failure after merge of the libata tree Stephen Rothwell
2014-02-26 13:49 ` Tejun Heo [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-01-06 14:08 Stephen Rothwell
2022-01-06 23:58 ` Damien Le Moal
2022-01-07  0:17   ` Stephen Rothwell
2022-01-07  1:28     ` Damien Le Moal
2016-05-09  0:14 Stephen Rothwell
2015-09-17  4:03 Stephen Rothwell
2015-09-17 11:14 ` Luis de Bethencourt
2014-04-24  1:17 Stephen Rothwell
2014-04-24 12:25 ` Tejun Heo
2013-08-27  2:50 Stephen Rothwell
2013-08-27  5:52 ` Aaron Lu
2013-08-27 18:09   ` Tejun Heo
2013-08-19  1:54 Stephen Rothwell
2013-08-19  3:18 ` Terry Suereth
2013-08-19 13:40   ` Tejun Heo
2012-07-02  2:10 Stephen Rothwell
2012-07-02  2:19 ` huang ying
2010-08-18  0:40 Stephen Rothwell
2010-08-18  0:46 ` Gwendal Grignou
2010-08-19 20:15   ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140226134915.GB17302@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).