From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751556AbaB1H5Q (ORCPT ); Fri, 28 Feb 2014 02:57:16 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:48852 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750942AbaB1H5P (ORCPT ); Fri, 28 Feb 2014 02:57:15 -0500 Date: Fri, 28 Feb 2014 10:56:50 +0300 From: Dan Carpenter To: Chase Southwood Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, Chase Southwood , linux-kernel@vger.kernel.org, abbotti@mev.co.uk Subject: Re: [PATCH 1/2] Staging: comedi: addi-data: fix lines that are over 80 characters Message-ID: <20140228075650.GI26776@mwanda> References: <1393572680-9521-1-git-send-email-chase.southwood@yahoo.com> <20140228075232.GH26776@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140228075232.GH26776@mwanda> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 28, 2014 at 10:52:32AM +0300, Dan Carpenter wrote: > On Fri, Feb 28, 2014 at 01:31:20AM -0600, Chase Southwood wrote: > > hwdrv_apci1564.c had numerous lines over the column limit. This patch > > splits all such lines to bring them in compliance with coding style. > > > > Signed-off-by: Chase Southwood > > --- > > .../comedi/drivers/addi-data/hwdrv_apci1564.c | 50 ++++++++++++++++------ > > 1 file changed, 36 insertions(+), 14 deletions(-) > > > > diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c > > index 2b47fa1..77030c5 100644 > > --- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c > > +++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c > > @@ -324,11 +324,15 @@ static int i_APCI1564_ConfigTimerCounterWatchdog(struct comedi_device *dev, > > inl(devpriv->i_IobaseAmcc + APCI1564_TIMER + > > APCI1564_TCW_PROG); > > ul_Command1 = ul_Command1 & 0xFFFFF9FEUL; > > - outl(ul_Command1, devpriv->i_IobaseAmcc + APCI1564_TIMER + APCI1564_TCW_PROG); /* Stop The Timer */ > > + /* Stop The Timer */ > > + outl(ul_Command1, devpriv->i_IobaseAmcc + APCI1564_TIMER + > > + APCI1564_TCW_PROG); > > Just make a helper function so that you can call it like this: > > static void outl_1564_timer(struct addi_private *devpriv, unsigned int cmd, > unsigned int reg) > { > outl(cmd, devpriv->i_IobaseAmcc + APCI1564_TIMER, reg); ^^^ Should be "devpriv->i_IobaseAmcc + APCI1564_TIMER + reg" obviously. regards, dan carpenter