> > Also, the I2C tracing has first 'f' then 'a', that should be consistent, > > too. > > Flags first or address first? Do you have a preference (for both)? I'd say address first, yet no strong preference. > > Can we have something like this for 'flags'? > > There's a __print_flags() which should work. One thing I'm concerned about > there is how do we handle more flags being added - does that count as an ABI > break if the printed format changes? Not sure, I mean, this is debug output, no? > SMBus flags are basically the same as I2C flags, right? Basically, yes. Thanks, Wolfram