From: Steven Rostedt <rostedt@goodmis.org>
To: Filipe Brandenburger <filbranden@google.com>
Cc: Li Zefan <lizefan@huawei.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] tracing: introduce a trace_data_offset struct to store array size
Date: Mon, 3 Mar 2014 15:48:26 -0500 [thread overview]
Message-ID: <20140303154826.570c658f@gandalf.local.home> (raw)
In-Reply-To: <1393651938-16418-4-git-send-email-filbranden@google.com>
You're right, this one will bring up discussion.
On Fri, 28 Feb 2014 21:32:18 -0800
Filipe Brandenburger <filbranden@google.com> wrote:
> Commit 7d536cb3f stores the length of the array in the high 16 bits of
> the offset field. Using a struct with two separate 16 bit fields makes
> it cleaner.
>
> Tested: Boot kernel with this change, set a 'filename ~ "/usr/bin/pst*"'
> regex filter on events/sched/sched_process_exec/filter, enabled tracing,
> checked that calling pstree would log the trace event as expected.
>
I just applied this and tested it on my PPC64 box, and it gives me the
following:
without patch:
pst2pdf-3506 [000] 120.700910: sched_process_exec: filename=/usr/bin/pst2pdf pid=3506 old_pid=3506
With patch:
pstopnm-4432 [001] 1490.246765: sched_process_exec: filename= pid=4432 old_pid=4432
-- Steve
next prev parent reply other threads:[~2014-03-03 20:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-01 5:32 [PATCH 0/3] tracing: fix macro expansion and refactor some of dynamic_array support Filipe Brandenburger
2014-03-01 5:32 ` [PATCH 1/3] tracing: correctly expand len expressions from __dynamic_array macro Filipe Brandenburger
2014-03-03 19:51 ` Steven Rostedt
2014-03-03 19:57 ` Filipe Brandenburger
2014-03-01 5:32 ` [PATCH 2/3] tracing: evaluate len expression only once in " Filipe Brandenburger
2014-03-01 5:32 ` [PATCH 3/3] tracing: introduce a trace_data_offset struct to store array size Filipe Brandenburger
2014-03-03 20:48 ` Steven Rostedt [this message]
2014-03-03 20:59 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140303154826.570c658f@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=filbranden@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).