linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josh Cartwright <joshc@codeaurora.org>
To: S?ren Brinkmann <soren.brinkmann@xilinx.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>, Rob Landley <rob@landley.net>,
	Russell King <linux@arm.linux.org.uk>,
	Michal Simek <michal.simek@xilinx.com>,
	Wolfram Sang <wsa@the-dreams.de>,
	devicetree@vger.kernel.org, Harini Katakam <harinik@xilinx.com>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] i2c: Add driver for Cadence I2C controller
Date: Tue, 4 Mar 2014 11:04:01 -0600	[thread overview]
Message-ID: <20140304170401.GA18529@joshc.qualcomm.com> (raw)
In-Reply-To: <8af0e222-6337-4ec4-b718-099a9decc5ec@TX2EHSMHS034.ehs.local>

On Fri, Feb 28, 2014 at 07:06:29PM -0800, S?ren Brinkmann wrote:
> On Fri, 2014-02-28 at 04:00PM -0800, Soren Brinkmann wrote:
> > Add a driver for the Cadence I2C controller. This controller is for
> > example found in Xilinx Zynq.
> > 
> > Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> > ---
> >  .../devicetree/bindings/i2c/i2c-cadence.txt        |  21 +
> >  MAINTAINERS                                        |   1 +
> >  drivers/i2c/busses/Kconfig                         |   7 +
> >  drivers/i2c/busses/Makefile                        |   1 +
> >  drivers/i2c/busses/i2c-cadence.c                   | 901 +++++++++++++++++++++
> >  5 files changed, 931 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/i2c/i2c-cadence.txt
> >  create mode 100644 drivers/i2c/busses/i2c-cadence.c
> > 
> [...]
> > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> > index f5ed03164d86..7806c1654068 100644
> > --- a/drivers/i2c/busses/Kconfig
> > +++ b/drivers/i2c/busses/Kconfig
> > @@ -375,6 +375,13 @@ config I2C_BLACKFIN_TWI_CLK_KHZ
> >  	help
> >  	  The unit of the TWI clock is kHz.
> >  
> > +config I2C_CADENCE
> > +	tristate "Cadence I2C Controller"
> > +	depends on ARCH_ZYNQ
> This can be reduced to a dependency on COMMON_CLK only, I think.

Do you really need to depend on COMMON_CLK?  Most of the clk_* API's are
properly stubbed when !HAVE_CLK.

Also, you may want to split out the device tree bindings in a separate
patch for separate review.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

  reply	other threads:[~2014-03-04 17:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-01  0:00 [PATCH 1/2] i2c: Add driver for Cadence I2C controller Soren Brinkmann
2014-03-01  0:00 ` [PATCH 2/2] ARM: zynq: dt: Add I2C nodes to Zynq device tree Soren Brinkmann
2014-03-01  2:28   ` Sören Brinkmann
2014-03-01  3:06 ` [PATCH 1/2] i2c: Add driver for Cadence I2C controller Sören Brinkmann
2014-03-04 17:04   ` Josh Cartwright [this message]
2014-03-04 17:20     ` Sören Brinkmann
2014-03-04 16:39 ` Sören Brinkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140304170401.GA18529@joshc.qualcomm.com \
    --to=joshc@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=harinik@xilinx.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=michal.simek@xilinx.com \
    --cc=pawel.moll@arm.com \
    --cc=rob@landley.net \
    --cc=robh+dt@kernel.org \
    --cc=soren.brinkmann@xilinx.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).