From: Ben Widawsky <ben@bwidawsk.net>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
intel-gfx@lists.freedesktop.org, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] linux-next: build failure after merge of the drm-intel tree
Date: Tue, 18 Mar 2014 18:54:15 -0700 [thread overview]
Message-ID: <20140319015415.GD7956@bwidawsk.net> (raw)
In-Reply-To: <20140318211842.017be730@gandalf.local.home>
On Tue, Mar 18, 2014 at 09:18:42PM -0400, Steven Rostedt wrote:
> On Wed, 19 Mar 2014 11:53:50 +1100
> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
>
> > Caused by commit a25ca17c1eac ("drm/i915: Do not dereference pointers
> > from ring buffer in evict event").
> >
> > I have used the drm-intel tree from next-20140318 for today.
> >
>
> Bah! I'm still suffering from jet lag (just came back from Linux-Tage
> in Chemnitz).
>
> The next time I compile test a patch for a module, I'll make sure I have
> that module's config option set :-( The woe of using localmodconfig. I
> should have picked the box with the i915. :-/
>
> Below is the fix. I'll repost a v2 of the original patch.
>
> Sorry about that.
>
I was about to send out the same fix when I saw this.
Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
> -- Steve
>
> diff --git a/drivers/gpu/drm/i915/i915_trace.h b/drivers/gpu/drm/i915/i915_trace.h
> index f3e8a90..783ae08 100644
> --- a/drivers/gpu/drm/i915/i915_trace.h
> +++ b/drivers/gpu/drm/i915/i915_trace.h
> @@ -243,7 +243,7 @@ TRACE_EVENT(i915_gem_evict_vm,
> ),
>
> TP_fast_assign(
> - __entry->dev = dev->primary->index;
> + __entry->dev = vm->dev->primary->index;
> __entry->vm = vm;
> ),
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ben Widawsky, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-03-19 2:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 0:53 linux-next: build failure after merge of the drm-intel tree Stephen Rothwell
2014-03-19 1:18 ` Steven Rostedt
2014-03-19 1:54 ` Ben Widawsky [this message]
2014-03-19 7:20 ` [Intel-gfx] " Daniel Vetter
2016-05-23 2:24 Stephen Rothwell
2016-05-23 8:55 ` [Intel-gfx] " Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140319015415.GD7956@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).