Re: [PATCH 04/19] perf: Allow ability to map cpus to nodes easily

From: Jiri Olsa <jolsa@redhat.com>
To: Don Zickus <dzickus@redhat.com>
Cc: acme@ghostprotocols.net, LKML <linux-kernel@vger.kernel.org>,
	jmario@redhat.com, fowles@inreach.com, eranian@google.com
Subject: Re: [PATCH 04/19] perf: Allow ability to map cpus to nodes easily
Date: Wed, 19 Mar 2014 14:22:59 +0100	[thread overview]
Message-ID: <20140319132259.GA16181@krava.brq.redhat.com> (raw)
In-Reply-To: <1393609388-40489-5-git-send-email-dzickus@redhat.com>

On Fri, Feb 28, 2014 at 12:42:53PM -0500, Don Zickus wrote:

SNIP

> +
> +/* Determine highest possible node in the system for sparse allocation */
> +static void set_max_node_num(void)
> +{
> +	FILE *fp;
> +	char buf[256];
> +	int num;
> +
> +	/* set up default */
> +	max_node_num = 8;
> +
> +	/* get the highest possible cpu number for a sparse allocation */
> +	fp = fopen("/sys/devices/system/node/possible", "r");
> +	if (!fp)
> +		goto out;
> +
> +	num = fread(&buf, 1, sizeof(buf), fp);
> +	if (!num)
> +		goto out_close;
> +	buf[num] = '\0';
> +
> +	/* start on the right, to find highest node num */
> +	while (--num) {
> +		if ((buf[num] == ',') || (buf[num] == '-')) {
> +			num++;
> +			break;
> +		}
> +	}
> +	if (sscanf(&buf[num], "%d", &max_node_num) < 1)
> +		goto out_close;
> +
> +	max_node_num++;
> +
> +	fclose(fp);
> +	return;

these ^^^ inners should go into single function and be used in 
both set_max_cpu_num and set_max_node_num functions

jirka