From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754350AbaDOOZM (ORCPT ); Tue, 15 Apr 2014 10:25:12 -0400 Received: from top.free-electrons.com ([176.31.233.9]:40960 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751037AbaDOOZF (ORCPT ); Tue, 15 Apr 2014 10:25:05 -0400 Date: Tue, 15 Apr 2014 16:20:24 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: Linus Walleij , Johannes Berg , "John W. Linville" , Arnd Bergmann , Heikki Krogerus , Mika Westerberg , Alexandre Courbot , Stephen Warren , linux-gpio@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH 1/7] gpiolib: gpiolib-of: Implement device tree gpio-names based lookup Message-ID: <20140415142024.GD3207@lukather> References: <1397544101-18135-1-git-send-email-wens@csie.org> <1397544101-18135-2-git-send-email-wens@csie.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="DiL7RhKs8rK9YGuF" Content-Disposition: inline In-Reply-To: <1397544101-18135-2-git-send-email-wens@csie.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --DiL7RhKs8rK9YGuF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Chen-Yu, On Tue, Apr 15, 2014 at 02:41:35PM +0800, Chen-Yu Tsai wrote: > This patch provides of_get_gpiod_flags_by_name(), which looks up GPIO > phandles by name only, through gpios/gpio-names, and not by index. IIRC, gpios only uses the *-gpios properties, and not gpios/gpio-names pattern seen on various other things. Is it some new property you introduce? If so, please add it to the documentation. Now, I'm not sure that having two distinct representations of GPIOs in the DT is a good thing. Yes, it's looking odd compared to other similar bindings, but it's what we have to deal with. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --DiL7RhKs8rK9YGuF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQIcBAEBAgAGBQJTTUAnAAoJEBx+YmzsjxAgE10P/iXHV6FcwR6t9LG80jHi9/Mz blvHZyxUdZFxmsdH3g8aWFJQ18vMyaMi3H2ynAWA9a5vx1jZeycmrUvpghYe97vc QcrRcTIhlu00vPLR9bANjKFixmQ7SYMpdkIKSoMT1nDqwogcu2eixjT4VO2EXORU mAOpqgD8wVPmvy75i++9RronnhQBrvjE7TPdeFeVCNYdL4Ddf4N9mFhmnwNc57Zp Qd9O+5yTkDPw35UMjtNPCuvyb5BtO8o/38M1rTP+hjGEGyYT8BmTS+nZuyIpgXnc GdYh3OvkI/8TZNUwOxs+06IjG6IeystiYGlvcVX/PRGFk5olT5dKsoPbqWicV2xd 18LdhwfIsikGfOazIzpu9yo50cX/x95R/YAjHVg/sgEU49Vj/+R4wYVLaM76ipws 0I0JCovXk0NQnPOElcelVbnMgVuf3W5/pNW1YTuxM0+4ToLrMN5R3Rc+uIzwqqed BggdFPfwx8hgEJy9XyCU8r0fFUp0vDzTkgxBgiOKWHW/SoUicSOpGbkC3AGgk+0W y6Qms1hlzyi5n8JoDW5N89HWhYwkGUzquoFZBI+a++lD4H5GepOl5yuVrBPbgnbk efIKFif2xdnrSFrfU/ujwlYj+k6FNbH9F11LzZsi0bUHcBdGef6S5hVNAMzrlF/u a/LUrtmdTYCeZLc2024f =WQtb -----END PGP SIGNATURE----- --DiL7RhKs8rK9YGuF--