linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Masanari Iida <standby24x7@gmail.com>
Cc: a.p.zijlstra@chello.nl, paulus@samba.org, mingo@redhat.com,
	acme@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf test x86: Fit memory leak in sample_ustack()
Date: Sun, 20 Apr 2014 00:19:13 +0200	[thread overview]
Message-ID: <20140419221913.GA6234@krava.redhat.com> (raw)
In-Reply-To: <1397920601-27712-1-git-send-email-standby24x7@gmail.com>

On Sun, Apr 20, 2014 at 12:16:41AM +0900, Masanari Iida wrote:
> buf is not freed, when kernel failed to get stack map
> and return.
> 
> Signed-off-by: Masanari Iida <standby24x7@gmail.com>

Acked-by: Jiri Olsa <jolsa@redhat.com>

thanks,
jirka

> ---
>  tools/perf/arch/x86/tests/dwarf-unwind.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/perf/arch/x86/tests/dwarf-unwind.c b/tools/perf/arch/x86/tests/dwarf-unwind.c
> index b602ad9..68f2711 100644
> --- a/tools/perf/arch/x86/tests/dwarf-unwind.c
> +++ b/tools/perf/arch/x86/tests/dwarf-unwind.c
> @@ -26,6 +26,7 @@ static int sample_ustack(struct perf_sample *sample,
>  	map = map_groups__find(&thread->mg, MAP__FUNCTION, (u64) sp);
>  	if (!map) {
>  		pr_debug("failed to get stack map\n");
> +		kfree(buf);
>  		return -1;
>  	}
>  
> -- 
> 1.9.2.468.g3f0c02a
> 

  reply	other threads:[~2014-04-19 22:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-19 15:16 [PATCH] perf test x86: Fit memory leak in sample_ustack() Masanari Iida
2014-04-19 22:19 ` Jiri Olsa [this message]
2014-04-19 22:33   ` Jiri Olsa
2014-04-21 14:37 ` [PATCH/v2] " Masanari Iida
2014-04-23 13:13   ` [tip:perf/urgent] perf tests x86: Fix " tip-bot for Masanari Iida

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140419221913.GA6234@krava.redhat.com \
    --to=jolsa@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=paulus@samba.org \
    --cc=standby24x7@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).