From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755413AbaDVJ7a (ORCPT ); Tue, 22 Apr 2014 05:59:30 -0400 Received: from cantor2.suse.de ([195.135.220.15]:35221 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754420AbaDVJ71 (ORCPT ); Tue, 22 Apr 2014 05:59:27 -0400 Date: Tue, 22 Apr 2014 11:59:23 +0200 From: Michal Hocko To: Jianyu Zhan Cc: hannes@cmpxchg.org, bsingharora@gmail.com, kamezawa.hiroyu@jp.fujitsu.com, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mm/memcontrol.c: introduce helper mem_cgroup_zoneinfo_zone() Message-ID: <20140422095923.GD29311@dhcp22.suse.cz> References: <1397862103-31982-1-git-send-email-nasa4836@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1397862103-31982-1-git-send-email-nasa4836@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat 19-04-14 07:01:43, Jianyu Zhan wrote: > introduce helper mem_cgroup_zoneinfo_zone(). This will make > mem_cgroup_iter() code more compact. I dunno. Helpers are usually nice but this one adds more code then it removes. It also doesn't help the generated code. So I don't see any reason to merge it. > Signed-off-by: Jianyu Zhan > --- > mm/memcontrol.c | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index e0ce15c..80d9e38 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -683,6 +683,15 @@ mem_cgroup_zoneinfo(struct mem_cgroup *memcg, int nid, int zid) > return &memcg->nodeinfo[nid]->zoneinfo[zid]; > } > > +static struct mem_cgroup_per_zone * > +mem_cgroup_zoneinfo_zone(struct mem_cgroup *memcg, struct zone *zone) > +{ > + int nid = zone_to_nid(zone); > + int zid = zone_idx(zone); > + > + return mem_cgroup_zoneinfo(memcg, nid, zid); > +} > + > struct cgroup_subsys_state *mem_cgroup_css(struct mem_cgroup *memcg) > { > return &memcg->css; > @@ -1232,11 +1241,9 @@ struct mem_cgroup *mem_cgroup_iter(struct mem_cgroup *root, > > rcu_read_lock(); > if (reclaim) { > - int nid = zone_to_nid(reclaim->zone); > - int zid = zone_idx(reclaim->zone); > struct mem_cgroup_per_zone *mz; > > - mz = mem_cgroup_zoneinfo(root, nid, zid); > + mz = mem_cgroup_zoneinfo_zone(root, reclaim->zone); > iter = &mz->reclaim_iter[reclaim->priority]; > if (prev && reclaim->generation != iter->generation) { > iter->last_visited = NULL; > @@ -1340,7 +1347,7 @@ struct lruvec *mem_cgroup_zone_lruvec(struct zone *zone, > goto out; > } > > - mz = mem_cgroup_zoneinfo(memcg, zone_to_nid(zone), zone_idx(zone)); > + mz = mem_cgroup_zoneinfo_zone(memcg, zone); > lruvec = &mz->lruvec; > out: > /* > -- > 1.9.0.GIT > -- Michal Hocko SUSE Labs