From: Jeff Layton <jlayton@redhat.com>
To: ams@gnu.org
Cc: libc-alpha@sourceware.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, tytso@mit.edu, dalias@libc.org,
mtk.manpages@gmail.com, samba-technical@lists.samba.org,
nfs-ganesha-devel@lists.sourceforge.net, carlos@redhat.com,
metze@samba.org, hch@infradead.org, bharrosh@panasas.com
Subject: Re: [RFC][glibc PATCH] fcntl-linux.h: add new definitions and manual updates for open file description locks
Date: Wed, 23 Apr 2014 11:28:43 -0400 [thread overview]
Message-ID: <20140423112843.77889d16@tlielax.poochiereds.net> (raw)
In-Reply-To: <E1Wcyo3-0000Eg-UC@fencepost.gnu.org>
On Wed, 23 Apr 2014 11:09:51 -0400
ams@gnu.org (Alfred M. Szmidt) wrote:
> @@ -2890,7 +2894,7 @@ Get flags associated with the open file. @xref{File Status Flags}.
> Set flags associated with the open file. @xref{File Status Flags}.
>
> @item F_GETLK
> -Get a file lock. @xref{File Locks}.
> +Test a file lock. @xref{File Locks}.
>
> F_GETLK does get the (first) lock which blocks; it doesn't test for
> it. "Retrieves information about the first blocking lock ..." or
> something might be better than the original
>
> @@ -2898,6 +2902,18 @@ Set or clear a file lock. @xref{File Locks}.
> @item F_SETLKW
> Like @code{F_SETLK}, but wait for completion. @xref{File Locks}.
>
> +@item F_OFD_GETLK
> +Test a open file description lock. @xref{Open File Description Locks}.
> +Specific to Linux.
>
> Likewise. You infact write that it does get the lock information
> later in the document wrt. F_OFD_GETLK.
Sorry, I disagree here...GETLK is really a misnomer, IMO. TESTLK would
have been a better name.
It's a way to test whether a particular lock can be applied, and to
return information about a conflicting lock if it can't. If, for
instance there is no conflicting lock, then you don't "get" any lock
information back (l_type just gets reset to F_UNLCK).
--
Jeff Layton <jlayton@redhat.com>
next prev parent reply other threads:[~2014-04-23 15:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 11:39 [RFC][glibc PATCH] fcntl-linux.h: add new definitions and manual updates for open file description locks Jeff Layton
2014-04-23 12:37 ` Michael Kerrisk (man-pages)
2014-04-23 15:09 ` Alfred M. Szmidt
2014-04-23 15:28 ` Jeff Layton [this message]
2014-04-23 19:00 ` Alfred M. Szmidt
2014-04-23 19:13 ` Michael Kerrisk (man-pages)
2014-04-23 19:23 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423112843.77889d16@tlielax.poochiereds.net \
--to=jlayton@redhat.com \
--cc=ams@gnu.org \
--cc=bharrosh@panasas.com \
--cc=carlos@redhat.com \
--cc=dalias@libc.org \
--cc=hch@infradead.org \
--cc=libc-alpha@sourceware.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=metze@samba.org \
--cc=mtk.manpages@gmail.com \
--cc=nfs-ganesha-devel@lists.sourceforge.net \
--cc=samba-technical@lists.samba.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).