From: Lee Jones <lee.jones@linaro.org>
To: Doug Anderson <dianders@chromium.org>
Cc: swarren@nvidia.com, wsa@the-dreams.de, abrestic@chromium.org,
dgreid@chromium.org, olof@lixom.net, sjg@chromium.org,
linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org,
David Hendricks <dhendrix@chromium.org>,
sameo@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/7] mfd: cros_ec: spi: calculate delay between transfers correctly
Date: Wed, 23 Apr 2014 13:33:41 +0100 [thread overview]
Message-ID: <20140423123341.GB640@lee--X1> (raw)
In-Reply-To: <1398185154-19404-2-git-send-email-dianders@chromium.org>
> From: David Hendricks <dhendrix@chromium.org>
>
> To avoid spamming the EC we calculate the time between the previous
> transfer and the current transfer and force a delay if the time delta
> is too small.
>
> However, a small miscalculation causes the delay period to be
> far too short. Most noticably this impacts commands with a long
> turnaround time such as EC firmware reads and writes.
>
> Signed-off-by: David Hendricks <dhendrix@chromium.org>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Tested-by: Andrew Bresticker <abrestic@chromium.org>
> Tested-by: Stephen Warren <swarren@nvidia.com>
> ---
> Changes in v2: None
>
> drivers/mfd/cros_ec_spi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Waiting for other subsystems to Ack, so for now:
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-04-23 12:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 16:45 [PATCH v2 0/7] Add cros_ec changes for newer boards Doug Anderson
2014-04-22 16:45 ` [PATCH v2 1/7] mfd: cros_ec: spi: calculate delay between transfers correctly Doug Anderson
2014-04-23 12:33 ` Lee Jones [this message]
2014-04-22 16:45 ` [PATCH v2 2/7] mfd: cros_ec: spi: Add mutex to cros_ec_spi Doug Anderson
2014-04-23 12:34 ` Lee Jones
2014-04-22 16:45 ` [PATCH v2 3/7] mfd: cros_ec: spi: Make the cros_ec_spi timeout more reliable Doug Anderson
2014-04-23 12:35 ` Lee Jones
2014-04-22 16:45 ` [PATCH v2 4/7] mfd: cros_ec: spi: Increase cros_ec_spi deadline from 5ms to 100ms Doug Anderson
2014-04-23 12:36 ` Lee Jones
2014-04-22 16:45 ` [PATCH v2 5/7] mfd: cros_ec: Sync to the latest cros_ec_commands.h from EC sources Doug Anderson
2014-04-23 12:36 ` Lee Jones
2014-04-22 16:45 ` [PATCH v2 6/7] i2c: ChromeOS EC tunnel driver Doug Anderson
2014-04-23 12:37 ` Lee Jones
2014-04-29 12:33 ` Wolfram Sang
2014-04-22 16:45 ` [PATCH v2 7/7] ARM: tegra: Add the EC i2c tunnel to tegra124-venice2 Doug Anderson
2014-04-23 12:32 ` [PATCH v2 0/7] Add cros_ec changes for newer boards Lee Jones
2014-04-23 16:20 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423123341.GB640@lee--X1 \
--to=lee.jones@linaro.org \
--cc=abrestic@chromium.org \
--cc=dgreid@chromium.org \
--cc=dhendrix@chromium.org \
--cc=dianders@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=olof@lixom.net \
--cc=sameo@linux.intel.com \
--cc=sjg@chromium.org \
--cc=swarren@nvidia.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).