From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754898AbaDWNRg (ORCPT ); Wed, 23 Apr 2014 09:17:36 -0400 Received: from mail-ee0-f44.google.com ([74.125.83.44]:55239 "EHLO mail-ee0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751773AbaDWNRd (ORCPT ); Wed, 23 Apr 2014 09:17:33 -0400 From: Grant Likely Subject: Re: [PATCH 0/3] of: dts: enable memory@0 quirk for PPC32 only To: Leif Lindholm Cc: Rob Herring , "linux-kernel@vger.kernel.org" , Linaro Patches , "devicetree@vger.kernel.org" , linuxppc-dev , Mark Rutland In-Reply-To: <20140422140526.GK5904@bivouac.eciton.net> References: <1397756521-29387-1-git-send-email-leif.lindholm@linaro.org> <20140418124821.GE5904@bivouac.eciton.net> <20140422130829.CA29DC4042C@trevor.secretlab.ca> <20140422140526.GK5904@bivouac.eciton.net> Date: Wed, 23 Apr 2014 14:17:20 +0100 Message-Id: <20140423131720.8C978C408D2@trevor.secretlab.ca> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 22 Apr 2014 15:05:26 +0100, Leif Lindholm wrote: > On Tue, Apr 22, 2014 at 02:08:29PM +0100, Grant Likely wrote: > > > I would prefer to see a "WARN_ON(!IS_ENABLED(CONFIG_PPC32));" added here. > > > > I completely agree. > > OK. So do we keep this around on unaffected architectures in perpetuity? > > Or can there be some cut-off date when the majority of DT-enabled > platforms can stop including this workaround which permits new incorrect > DTs to be implemented so long as they are incorrect in this particular > way? I'd be fine with a patch that can enable the workaround selectively for specific machines. Some people will still hit breakage, but we can fix that by adding their machine to the quirk list. g.