From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
Emilio Lopez <emilio@elopez.com.ar>,
Dan Williams <dan.j.williams@intel.com>,
Vinod Koul <vinod.koul@intel.com>,
devicetree@vger.kernel.org,
Mike Turquette <mturquette@linaro.org>,
andriy.shevchenko@intel.com, linux-kernel@vger.kernel.org,
zhuzhenhua@allwinnertech.com, shuge@allwinnertech.com,
linux-sunxi@googlegroups.com, kevin.z.m.zh@gmail.com,
sunny@allwinnertech.com, dmaengine@vger.kernel.org
Subject: Re: [PATCH v6 2/8] ARM: sunxi: Split out the various machines into separate files
Date: Wed, 23 Apr 2014 14:33:50 +0200 [thread overview]
Message-ID: <201404231433.51129.arnd@arndb.de> (raw)
In-Reply-To: <1397724379-15398-3-git-send-email-maxime.ripard@free-electrons.com>
On Thursday 17 April 2014, Maxime Ripard wrote:
> This will allow to add per-SoC hooks more easily.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
> arch/arm/mach-sunxi/Makefile | 6 +-
> arch/arm/mach-sunxi/restart.c | 104 +++++++++++++++++++++++++++
> arch/arm/mach-sunxi/restart.h | 20 ++++++
> arch/arm/mach-sunxi/sun4i.c | 36 ++++++++++
> arch/arm/mach-sunxi/sun5i.c | 37 ++++++++++
> arch/arm/mach-sunxi/sun6i.c | 49 +++++++++++++
> arch/arm/mach-sunxi/sun7i.c | 36 ++++++++++
> arch/arm/mach-sunxi/sunxi.c | 164 ------------------------------------------
> 8 files changed, 287 insertions(+), 165 deletions(-)
This doesn't look like a move in the right direction, and I don't see
the connection with the DMA driver.
> diff --git a/arch/arm/mach-sunxi/restart.c b/arch/arm/mach-sunxi/restart.c
> new file mode 100644
> index 000000000000..3b89727ee943
> --- /dev/null
> +++ b/arch/arm/mach-sunxi/restart.c
Splitting out the restart code is good, but please complete this by
moving it into a driver directory. My preferred location would be
within the watchdog driver, since it's really the same registers.
You can turn on the watchdog driver as built-in in the defconfig.
While it's not ideal that you can end up without a restart function
if the driver does not get loaded, I would still prefer that over
having the driver in the mach-sunxi directory.
An alternative would be to move the restart code into
drivers/power/reset.
> diff --git a/arch/arm/mach-sunxi/sunxi.c b/arch/arm/mach-sunxi/sunxi.c
> deleted file mode 100644
> index 460b5a4962ef..000000000000
> --- a/arch/arm/mach-sunxi/sunxi.c
Instead of splitting up this file, I think it would be better to
reduce the number of special hacks required per machine. Note that
for arm64 we require platforms not to have any code outside of
the drivers directory, and I'd like to get to the same situation
for much of arch/arm/mach-* as well.
Arnd
next prev parent reply other threads:[~2014-04-23 12:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 8:46 [PATCH v6 0/8] Add support for the Allwinner A31 DMA Controller Maxime Ripard
2014-04-17 8:46 ` [PATCH v6 1/8] clk: sunxi: Remove calls to clk_put Maxime Ripard
2014-04-17 8:46 ` [PATCH v6 2/8] ARM: sunxi: Split out the various machines into separate files Maxime Ripard
2014-04-23 12:33 ` Arnd Bergmann [this message]
2014-04-23 13:28 ` Maxime Ripard
2014-04-23 13:33 ` Arnd Bergmann
2014-04-17 8:46 ` [PATCH v6 3/8] ARM: sunxi: Move the clock protection to machine hooks Maxime Ripard
2014-04-23 12:39 ` Arnd Bergmann
2014-04-23 13:17 ` Maxime Ripard
2014-04-23 13:31 ` Arnd Bergmann
2014-05-13 1:30 ` Mike Turquette
2014-04-17 8:46 ` [PATCH v6 4/8] ARM: sun6i: Protect CPU clock Maxime Ripard
2014-04-17 8:46 ` [PATCH v6 5/8] ARM: sun6i: Protect SDRAM gating bit Maxime Ripard
2014-04-17 8:46 ` [PATCH v6 6/8] ARM: sun6i: Sort the NMI node by physical address Maxime Ripard
2014-04-23 12:39 ` Arnd Bergmann
2014-04-23 13:11 ` Maxime Ripard
2014-04-17 8:46 ` [PATCH v6 7/8] DMA: sun6i: Add driver for the Allwinner A31 DMA controller Maxime Ripard
2014-04-17 8:46 ` [PATCH v6 8/8] ARM: sun6i: dt: Add A31 DMA controller to DTSI Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201404231433.51129.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=andriy.shevchenko@intel.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=emilio@elopez.com.ar \
--cc=kevin.z.m.zh@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
--cc=mturquette@linaro.org \
--cc=shuge@allwinnertech.com \
--cc=sunny@allwinnertech.com \
--cc=vinod.koul@intel.com \
--cc=zhuzhenhua@allwinnertech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).