From: Eric Biggers <ebiggers3@gmail.com>
To: Benjamin LaHaise <bcrl@kvack.org>
Cc: Matthew Wilcox <willy@linux.intel.com>,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-aio@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] aio: Fix type of iterator variable in do_io_submit()
Date: Wed, 23 Apr 2014 10:24:59 -0500 [thread overview]
Message-ID: <20140423152459.GA7609@zzz.student-wireless05.macalester.edu> (raw)
In-Reply-To: <20140423144237.GY22552@kvack.org>
On Wed, Apr 23, 2014 at 10:42:37AM -0400, Benjamin LaHaise wrote:
> Practically speaking, this change has no effect. The io_submit() syscall
> will exit far before we even hit INT_MAX because of the limits on the
> number of iocbs.
Yes it looks like it doesn't actually make a difference due to the default
'aio-max-nr' limit of 1048576 (although you actually can submit just over twice
this many). In my opinion this change should still be made so that the
correctness of the code doesn't rely on that nonlocal assumption, however.
And/or the explicit limit of (LONG_MAX / sizeof(struct iocb *)) elements could
be changed to something lower, as Matthew suggested.
Eric
prev parent reply other threads:[~2014-04-23 15:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 22:57 [PATCH] aio: Fix type of iterator variable in do_io_submit() Eric Biggers
2014-04-23 14:16 ` Matthew Wilcox
2014-04-23 14:42 ` Benjamin LaHaise
2014-04-23 15:24 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423152459.GA7609@zzz.student-wireless05.macalester.edu \
--to=ebiggers3@gmail.com \
--cc=bcrl@kvack.org \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).