From: "Antoine Ténart" <antoine.tenart@free-electrons.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Mike Turquette <mturquette@linaro.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH 5/5] ARM: berlin/dt: add sdio clocks to BG2Q
Date: Thu, 24 Apr 2014 00:49:46 +0200 [thread overview]
Message-ID: <20140423224946.GA12738@kwain> (raw)
In-Reply-To: <1398261667-12621-6-git-send-email-alexandre.belloni@free-electrons.com>
Alexandre,
On Wed, Apr 23, 2014 at 04:01:07PM +0200, Alexandre Belloni wrote:
> Add sdio clocks to the berlin2q.dtsi
> Also reorder the syspll node
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> arch/arm/boot/dts/berlin2q.dtsi | 28 +++++++++++++++++++++-------
> 1 file changed, 21 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi
> index 5925e6a16749..0fc826305614 100644
> --- a/arch/arm/boot/dts/berlin2q.dtsi
> +++ b/arch/arm/boot/dts/berlin2q.dtsi
> @@ -102,13 +102,6 @@
> reg = <0xdd0170 0x8>;
> };
>
> - syspll: syspll@ea0030 {
> - compatible = "marvell,berlin2q-pll";
> - clocks = <&smclk>;
> - #clock-cells = <0>;
> - reg = <0xea0030 0x8>;
> - };
> -
> apb@e80000 {
> compatible = "simple-bus";
> #address-cells = <1>;
> @@ -191,6 +184,27 @@
> };
> };
>
> + syspll: syspll@ea0030 {
> + compatible = "marvell,berlin2q-pll";
> + clocks = <&smclk>;
> + #clock-cells = <0>;
> + reg = <0xea0030 0x8>;
> + };
> +
> + sdio0xinclk: sdio0xinclk@ea0158 {
> + compatible = "marvell,berlin-clk";
> + clocks = <&syspll>;
> + #clock-cells = <0>;
> + reg = <0xea0158 4>;
I believe you can use
reg = <0xea0158 0x4>;
since you used an hex value in the previous node. Plus we tend to use
hex values elsewhere too.
> + };
> +
> + sdio1xinclk: sdio1xinclk@ea015c {
> + compatible = "marvell,berlin-clk";
> + clocks = <&syspll>;
> + #clock-cells = <0>;
> + reg = <0xea015c 4>;
Ditto. This also applies to BG2/BG2CD and the documentation patches.
Thanks!
Antoine
> + };
> +
> apb@fc0000 {
> compatible = "simple-bus";
> #address-cells = <1>;
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2014-04-23 22:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 14:01 [PATCH 0/5] Berlin: add clock support Alexandre Belloni
2014-04-23 14:01 ` [PATCH 1/5] clk: berlin: add support for clocks Alexandre Belloni
2014-04-23 17:03 ` Sebastian Hesselbarth
2014-04-23 17:10 ` Sebastian Hesselbarth
2014-04-23 14:01 ` [PATCH 2/5] clk: berlin: add berlin clocks DT bindings documentation Alexandre Belloni
2014-04-23 17:21 ` Sebastian Hesselbarth
2014-04-23 14:01 ` [PATCH 3/5] ARM: berlin/dt: add sdio clocks to BG2 Alexandre Belloni
2014-04-23 14:01 ` [PATCH 4/5] ARM: berlin/dt: add sdio clocks to BG2CD Alexandre Belloni
2014-04-23 22:51 ` Antoine Ténart
2014-04-23 14:01 ` [PATCH 5/5] ARM: berlin/dt: add sdio clocks to BG2Q Alexandre Belloni
2014-04-23 22:49 ` Antoine Ténart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423224946.GA12738@kwain \
--to=antoine.tenart@free-electrons.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).