From: Jiri Olsa <jolsa@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Jean Pihet <jean.pihet@linaro.org>,
Josh Boyer <jwboyer@fedoraproject.org>,
Masanari Iida <standby24x7@gmail.com>,
Namhyung Kim <namhyung@kernel.org>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Steven Rostedt <rostedt@goodmis.org>,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [GIT PULL 0/4] perf/urgent fixes
Date: Thu, 24 Apr 2014 13:43:26 +0200 [thread overview]
Message-ID: <20140424114326.GD1110@krava.brq.redhat.com> (raw)
In-Reply-To: <20140424064718.GD1104@gmail.com>
On Thu, Apr 24, 2014 at 08:47:18AM +0200, Ingo Molnar wrote:
SNIP
>
> In any case, your patch fixes the bug. With VF=1 I get this output:
>
> Auto-detecting system features:
> ... dwarf: [ on ]
> ... glibc: [ on ]
> ... gtk2: [ on ]
> ... libaudit: [ on ]
> ... libbfd: [ on ]
> ... libelf: [ on ]
> ... libnuma: [ on ]
> ... libperl: [ on ]
> ... libpython: [ on ]
> ... libslang: [ on ]
> ... libunwind: [ on ]
> ... libdw-dwarf-unwind: [ on ]
> ... DWARF post unwind library: libunwind
> ... backtrace: [ on ]
> ... fortify-source: [ on ]
> ... gtk2-infobar: [ on ]
> ... libelf-getphdrnum: [ on ]
> ... libelf-mmap: [ on ]
> ... libpython-version: [ on ]
> ... on-exit: [ on ]
> ... stackprotector-all: [ on ]
> ... timerfd: [ on ]
> ... libunwind-debug-frame: [ OFF ]
> ... bionic: [ OFF ]
> ... liberty: [ OFF ]
> ... liberty-z: [ OFF ]
> ... cplus-demangle: [ OFF ]
>
> So yes, your obervation that it's the -liberty +libbfd combination is
> correct.
>
> Tested-by: Ingo Molnar <mingo@kernel.org>
>
> Btw., when reading the patch and the Makefile it was not obvious to me
> what 'VF' stood for. It's pretty clear what CORE_FEATURE_TESTS and
VF - Verbose for Features ;-)
> LIB_FEATURE_TESTS means, but there's no comment for VF_FEATURE_TESTS
> and the name is not self-explanatory.
>
> I figured it out from a bit of git log digging that its purpose is to
> generate the 'verbose feature check' output. But the variable is not
> commented and the features it lists overlaps CORE_FEATURE_TESTS and
> LIB_FEATURE_TESTS - so perhaps a bit more explanation (and possible
> reduction in duplication) might be useful?
>
> If it said ALL_FEATURE_TESTS and used $(CORE_FEATURE_TESTS) as a
> baseline then that would be self-explanatory.
>
> (In a separate patch from the fix.)
ok, will add something along those lines ;-)
thanks,
jirka
next prev parent reply other threads:[~2014-04-24 11:43 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 11:31 [GIT PULL 0/4] perf/urgent fixes Jiri Olsa
2014-04-23 11:31 ` [PATCH 1/4] perf tests x86: Fix memory leak in sample_ustack() Jiri Olsa
2014-04-23 11:31 ` [PATCH 2/4] perf tools: Disable libdw unwind for all but x86 arch Jiri Olsa
2014-04-23 11:31 ` [PATCH 3/4] tools lib traceevent: Fix backward compatibility macros for pevent filter enums Jiri Olsa
2014-04-23 11:31 ` [PATCH 4/4] tools lib traceevent: Fix memory leak in pretty_print() Jiri Olsa
2014-04-23 13:09 ` [GIT PULL 0/4] perf/urgent fixes Ingo Molnar
2014-04-23 13:14 ` Ingo Molnar
2014-04-23 13:49 ` Jiri Olsa
2014-04-24 6:36 ` Ingo Molnar
2014-04-24 11:47 ` Jiri Olsa
2014-04-25 8:12 ` Ingo Molnar
2014-04-23 14:53 ` Jiri Olsa
2014-04-24 6:47 ` Ingo Molnar
2014-04-24 11:43 ` Jiri Olsa [this message]
2014-04-25 17:50 ` Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2018-06-02 14:59 Arnaldo Carvalho de Melo
2018-06-03 17:12 ` Ingo Molnar
2017-05-04 17:23 Arnaldo Carvalho de Melo
2017-05-04 17:44 ` Ingo Molnar
2016-01-26 14:32 Arnaldo Carvalho de Melo
2016-01-30 8:16 ` Ingo Molnar
2015-08-19 19:40 Arnaldo Carvalho de Melo
2015-08-20 9:48 ` Ingo Molnar
2015-07-09 15:45 Arnaldo Carvalho de Melo
2015-07-10 8:04 ` Ingo Molnar
2015-04-23 22:03 Arnaldo Carvalho de Melo
2015-04-24 2:02 ` Namhyung Kim
2015-04-24 2:09 ` Arnaldo Carvalho de Melo
2015-04-24 8:59 ` Javi Merino
2015-04-24 16:02 ` Arnaldo Carvalho de Melo
2015-04-24 16:05 ` Will Deacon
2015-01-03 2:55 Arnaldo Carvalho de Melo
2015-01-08 8:00 ` Ingo Molnar
2013-10-28 19:16 Arnaldo Carvalho de Melo
2013-10-29 8:10 ` Ingo Molnar
2012-05-30 0:11 Arnaldo Carvalho de Melo
2012-05-30 7:00 ` Ingo Molnar
2012-05-25 19:59 Arnaldo Carvalho de Melo
2012-05-25 21:46 ` Arnaldo Carvalho de Melo
2012-04-20 16:53 Arnaldo Carvalho de Melo
2012-04-25 7:08 ` Ingo Molnar
2012-03-01 17:25 Arnaldo Carvalho de Melo
2011-06-03 16:25 Arnaldo Carvalho de Melo
2011-06-04 10:13 ` Ingo Molnar
2011-06-04 10:29 ` Ingo Molnar
2010-12-16 12:00 Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140424114326.GD1110@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=ak@linux.intel.com \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jean.pihet@linaro.org \
--cc=jwboyer@fedoraproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
--cc=standby24x7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).