From: Steven Rostedt <rostedt@goodmis.org>
To: Mike Galbraith <umgwanakikbuti@gmail.com>
Cc: Nicholas Mc Guire <der.herr@hofr.at>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
linux-rt-users <linux-rt-users@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
John Kacur <jkacur@redhat.com>,
Clark Williams <williams@redhat.com>
Subject: Re: [ANNOUNCE] 3.14-rt1
Date: Wed, 30 Apr 2014 11:48:19 -0400 [thread overview]
Message-ID: <20140430114819.03e8c6ce@gandalf.local.home> (raw)
In-Reply-To: <1398870957.5220.2.camel@marge.simpson.net>
On Wed, 30 Apr 2014 17:15:57 +0200
Mike Galbraith <umgwanakikbuti@gmail.com> wrote:
> On Wed, 2014-04-30 at 11:11 -0400, Steven Rostedt wrote:
>
> > > Another little bug. This hunk of patches/stomp-machine-raw-lock.patch
> > > should be while (atomic_read(&done.nr_todo))
> > >
> > > @@ -647,7 +671,7 @@ int stop_machine_from_inactive_cpu(int (
> > > ret = multi_cpu_stop(&msdata);
> > >
> > > /* Busy wait for completion. */
> > > - while (!completion_done(&done.completion))
> > > + while (!atomic_read(&done.nr_todo))
> ^--- that ! needs to go away
> >
> > I don't see this in the code. That is, there is no "completion_done()"
> > in stop_machine_from_inactive_cpu(). It is already an atomic_read().
>
> Yes, but it should read "while (atomic_read(&done.nr_todo))"
Ah, this would have been better if you had sent a patch. I misread what
you talked about.
Yes, this was the culprit of my failures. After removing the '!', it
worked.
Care to send a patch :-)
-- Steve
next prev parent reply other threads:[~2014-04-30 15:48 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 18:57 [ANNOUNCE] 3.14-rt1 Sebastian Andrzej Siewior
2014-04-11 19:34 ` Pavel Vasilyev
2014-04-19 14:46 ` Mike Galbraith
2014-04-21 3:31 ` Mike Galbraith
2014-05-02 10:16 ` Sebastian Andrzej Siewior
2014-04-25 7:40 ` Mike Galbraith
2014-04-26 8:38 ` Mike Galbraith
2014-04-26 13:58 ` Mike Galbraith
2014-04-28 5:09 ` Mike Galbraith
2014-04-28 9:09 ` Mike Galbraith
2014-04-28 14:18 ` Steven Rostedt
2014-04-28 14:37 ` Mike Galbraith
2014-04-28 14:43 ` Mike Galbraith
2014-04-29 5:21 ` Mike Galbraith
2014-04-30 0:13 ` Steven Rostedt
2014-04-30 7:43 ` Mike Galbraith
2014-04-30 13:06 ` Mike Galbraith
2014-04-30 13:15 ` Steven Rostedt
2014-04-30 14:00 ` Mike Galbraith
2014-04-30 14:19 ` Steven Rostedt
2014-04-30 14:33 ` Steven Rostedt
2014-04-30 14:54 ` Mike Galbraith
2014-04-30 15:11 ` Steven Rostedt
2014-04-30 15:15 ` Mike Galbraith
2014-04-30 15:48 ` Steven Rostedt [this message]
2014-04-30 15:56 ` Mike Galbraith
2014-05-01 17:36 ` Mike Galbraith
2014-05-01 18:42 ` Steven Rostedt
2014-05-02 1:45 ` Mike Galbraith
2014-04-30 15:21 ` Mike Galbraith
2014-04-30 14:45 ` Mike Galbraith
2014-05-02 10:09 ` Sebastian Andrzej Siewior
2014-05-02 11:16 ` Mike Galbraith
2014-04-23 10:37 ` Mike Galbraith
2014-04-23 12:19 ` Steven Rostedt
2014-04-24 4:06 ` Mike Galbraith
2014-04-24 7:12 ` Sebastian Andrzej Siewior
2014-04-24 7:26 ` Mike Galbraith
2014-04-26 18:29 ` Fernando Lopez-Lezcano
2014-05-02 11:37 ` Sebastian Andrzej Siewior
2014-05-15 17:51 ` Fernando Lopez-Lezcano
2014-05-15 20:09 ` Fernando Lopez-Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140430114819.03e8c6ce@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=bigeasy@linutronix.de \
--cc=der.herr@hofr.at \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=umgwanakikbuti@gmail.com \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).