From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759296AbaD3RFh (ORCPT ); Wed, 30 Apr 2014 13:05:37 -0400 Received: from mail-pd0-f172.google.com ([209.85.192.172]:34255 "EHLO mail-pd0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759268AbaD3RFf (ORCPT ); Wed, 30 Apr 2014 13:05:35 -0400 Date: Wed, 30 Apr 2014 10:05:25 -0700 From: Guenter Roeck To: Pawel Moll Cc: Grant Likely , Rob Herring , Samuel Ortiz , Lee Jones , Arnd Bergmann , Greg Kroah-Hartman , Russell King , Mike Turquette , Liam Girdwood , Dmitry Eremin-Solenikov , Mark Brown , David Woodhouse , Jean Delvare , linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org, arm@kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] mfd: vexpress: Convert custom func API to regmap Message-ID: <20140430170525.GA3389@roeck-us.net> References: <1398707877-22596-3-git-send-email-pawel.moll@arm.com> <1398873686-8618-1-git-send-email-pawel.moll@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1398873686-8618-1-git-send-email-pawel.moll@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 30, 2014 at 05:01:26PM +0100, Pawel Moll wrote: > Components of the Versatile Express platform (configuration > microcontrollers on motherboard and daughterboards in particular) > talk to each other over a custom configuration bus. They > provide miscellaneous functions (from clock generator control > to energy sensors) which are represented as platform devices > (and Device Tree nodes). The transactions on the bus can > be generated by different "bridges" in the system, some > of which are universal for the whole platform (for the price > of high transfer latencies), others restricted to a subsystem > (but much faster). > > Until now drivers for such functions were using custom "func" > API, which is being replaced in this patch by regmap calls. > This required: > > * a rework (and move to drivers/bus directory, as suggested > by Samuel and Arnd) of the config bus core, which is much > simpler now and uses device model infrastructure (class) > to keep track of the bridges; non-DT case (soon to be > retired anyway) is simply covered by a special device > registration function > > * the new config-bus driver also takes over device population, > so there is no need for special matching table for > of_platform_populate nor "simple-bus" hack in the arm64 > model dtsi file (relevant bindings documentation has > been updated); this allows all the vexpress devices > fit into normal device model, making it possible > to remove plenty of early inits and other hacks in > the near future > > * adaptation of the syscfg bridge implementation in the > sysreg driver, again making it much simpler; there is > a special case of the "energy" function spanning two > registers, where they should be both defined in the tree > now, but backward compatibility is maintained in the code > > * modification of the relevant drivers: > > * hwmon - just a straight-forward API change > * power/reset driver - API change > * regulator - API change plus error handling > simplification > * osc clock driver - this one required larger rework > in order to turn in into a standard platform driver > > Signed-off-by: Pawel Moll > Acked-by: Mark Brown > Acked-by: Lee Jones For hwmon: Acked-by: Guenter Roeck