From: Andrew Morton <akpm@linux-foundation.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Michal Hocko <mhocko@suse.cz>, Jianyu Zhan <nasa4836@gmail.com>,
bsingharora@gmail.com, kamezawa.hiroyu@jp.fujitsu.com,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.com
Subject: Re: [PATCH 2/2] mm/memcontrol.c: introduce helper mem_cgroup_zoneinfo_zone()
Date: Fri, 2 May 2014 15:05:16 -0700 [thread overview]
Message-ID: <20140502150516.d42792bad53d86fb727816bd@linux-foundation.org> (raw)
In-Reply-To: <20140501125450.GA23420@cmpxchg.org>
On Thu, 1 May 2014 08:54:50 -0400 Johannes Weiner <hannes@cmpxchg.org> wrote:
> On Mon, Apr 28, 2014 at 05:04:26PM +0200, Michal Hocko wrote:
> > On Tue 22-04-14 11:59:23, Michal Hocko wrote:
> > > On Sat 19-04-14 07:01:43, Jianyu Zhan wrote:
> > > > introduce helper mem_cgroup_zoneinfo_zone(). This will make
> > > > mem_cgroup_iter() code more compact.
> > >
> > > I dunno. Helpers are usually nice but this one adds more code then it
> > > removes. It also doesn't help the generated code.
> > >
> > > So I don't see any reason to merge it.
> >
> > So should we drop it from mmotm?
>
> Yes, please.
>
> > > > Signed-off-by: Jianyu Zhan <nasa4836@gmail.com>
> > > > ---
> > > > mm/memcontrol.c | 15 +++++++++++----
> > > > 1 file changed, 11 insertions(+), 4 deletions(-)
>
> This helper adds no value, but more code and indirection.
>
> Cc'd Andrew - this is about
> mm-memcontrolc-introduce-helper-mem_cgroup_zoneinfo_zone.patch
> mm-memcontrolc-introduce-helper-mem_cgroup_zoneinfo_zone-checkpatch-fixes.patch
The patch seemed rather nice to me. mem_cgroup_zoneinfo_zone()
encapsulates a particular concept and gives it a name. That's better
than splattering the logic into callsites.
The patch makes no change to code size but that's because gcc is silly.
Mark mem_cgroup_zoneinfo_zone() as noinline and the patch shrinks
.text by 40 bytes.
next prev parent reply other threads:[~2014-05-02 22:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-18 23:01 [PATCH 2/2] mm/memcontrol.c: introduce helper mem_cgroup_zoneinfo_zone() Jianyu Zhan
2014-04-22 9:59 ` Michal Hocko
2014-04-28 15:04 ` Michal Hocko
2014-05-01 12:54 ` Johannes Weiner
2014-05-01 13:36 ` Johannes Weiner
2014-05-02 22:05 ` Andrew Morton [this message]
2014-05-02 23:29 ` Johannes Weiner
2014-05-02 23:31 ` Johannes Weiner
2014-05-05 15:35 ` Michal Hocko
2014-05-05 15:31 ` Michal Hocko
2014-05-05 21:36 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140502150516.d42792bad53d86fb727816bd@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=akpm@linux-foundation.com \
--cc=bsingharora@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=nasa4836@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).