From: Bjorn Helgaas <bhelgaas@google.com>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Russell King <linux@arm.linux.org.uk>,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
Grygorii Strashko <grygorii.strashko@ti.com>
Subject: Re: [PATCH v3 4/7] of: configure the platform device dma parameters
Date: Fri, 2 May 2014 10:54:59 -0600 [thread overview]
Message-ID: <20140502165459.GA29511@google.com> (raw)
In-Reply-To: <1398353407-2345-5-git-send-email-santosh.shilimkar@ti.com>
On Thu, Apr 24, 2014 at 11:30:04AM -0400, Santosh Shilimkar wrote:
> Retrieve DMA configuration from DT and setup platform device's DMA
> parameters. The DMA configuration in DT has to be specified using
> "dma-ranges" and "dma-coherent" properties if supported.
>
> We setup dma_pfn_offset using "dma-ranges" and dma_coherent_ops
> using "dma-coherent" device tree properties.
>
> The set_arch_dma_coherent_ops macro has to be defined by arch if
> it supports coherent dma_ops. Otherwise, set_arch_dma_coherent_ops() is
> declared as nop.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Olof Johansson <olof@lixom.net>
> Cc: Grant Likely <grant.likely@linaro.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> ---
> drivers/of/platform.c | 48 ++++++++++++++++++++++++++++++++++++++++---
> include/linux/dma-mapping.h | 7 +++++++
> 2 files changed, 52 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/of/platform.c b/drivers/of/platform.c
> index 48de98f..270c0b9 100644
> --- a/drivers/of/platform.c
> +++ b/drivers/of/platform.c
> @@ -187,6 +187,50 @@ struct platform_device *of_device_alloc(struct device_node *np,
> EXPORT_SYMBOL(of_device_alloc);
>
> /**
> + * of_dma_configure - Setup DMA configuration
> + * @dev: Device to apply DMA configuration
> + *
> + * Try to get devices's DMA configuration from DT and update it
> + * accordingly.
> + *
> + * In case if platform code need to use own special DMA configuration,it
> + * can use Platform bus notifier and handle BUS_NOTIFY_ADD_DEVICE event
> + * to fix up DMA configuration.
> + */
> +static void of_dma_configure(struct device *dev)
> +{
> + u64 dma_addr, paddr, size;
> + int ret;
> +
> + dev->coherent_dma_mask = DMA_BIT_MASK(32);
> + if (!dev->dma_mask)
> + dev->dma_mask = &dev->coherent_dma_mask;
> +
> + /*
> + * if dma-coherent property exist, call arch hook to setup
> + * dma coherent operations.
> + */
> + if (of_dma_is_coherent(dev->of_node)) {
> + set_arch_dma_coherent_ops(dev);
> + dev_dbg(dev, "device is dma coherent\n");
> + }
> +
> + /*
> + * if dma-ranges property doesn't exist - just return else
> + * setup the dma offset
> + */
> + ret = of_dma_get_range(dev->of_node, &dma_addr, &paddr, &size);
> + if ((ret == -ENODEV) || (ret < 0)) {
> + dev_dbg(dev, "no dma range information to setup\n");
> + return;
> + }
> +
> + /* DMA ranges found. Calculate and set dma_pfn_offset */
> + dev->dma_pfn_offset = PFN_DOWN(paddr - dma_addr);
> + dev_dbg(dev, "dma_pfn_offset(%#08lx)\n", dev->dma_pfn_offset);
Is this effectively the same as an IOMMU that applies a constant offset
to the bus address? Could or should this be done by adding a simple IOMMU
driver instead of adding dma_pfn_offset to struct device?
If we had both dma-ranges (and we set dma_pfn_offset as you do here) and an
IOMMU, how would the combination work? If the IOMMU driver managed
dma_pfn_offset internally, it seems like we'd have two entities dealing
with it. If the IOMMU driver doesn't use dma_pfn_offset, it seems like
it would be exposing a weird intermediate address space that's not usable
by either CPU or device.
next prev parent reply other threads:[~2014-05-02 16:55 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 15:30 [PATCH v3 0/7] of: setup dma parameters using dma-ranges and dma-coherent Santosh Shilimkar
2014-04-24 15:30 ` [PATCH v3 1/7] device: introduce per device dma_pfn_offset Santosh Shilimkar
2014-05-02 1:01 ` Rob Herring
2014-04-24 15:30 ` [PATCH v3 2/7] of: introduce of_dma_get_range() helper Santosh Shilimkar
2014-05-02 1:06 ` Rob Herring
2014-04-24 15:30 ` [PATCH v3 3/7] of: introduce of_dma_is_coherent() helper Santosh Shilimkar
2014-05-02 0:56 ` Rob Herring
2014-05-05 21:45 ` Santosh Shilimkar
2014-05-05 22:06 ` Rob Herring
2014-04-24 15:30 ` [PATCH v3 4/7] of: configure the platform device dma parameters Santosh Shilimkar
2014-04-29 14:41 ` Grant Likely
2014-04-30 14:19 ` Santosh Shilimkar
2014-05-01 13:12 ` Grant Likely
2014-05-01 13:16 ` Santosh Shilimkar
2014-05-02 9:58 ` Arnd Bergmann
2014-05-02 13:13 ` Santosh Shilimkar
2014-05-02 15:13 ` Arnd Bergmann
2014-05-27 12:56 ` Grant Likely
2014-05-27 13:30 ` Arnd Bergmann
2014-05-28 8:23 ` Linus Walleij
2014-05-28 13:29 ` Arnd Bergmann
2014-05-28 13:32 ` Linus Walleij
2014-05-28 14:04 ` Santosh Shilimkar
2014-05-29 14:01 ` Linus Walleij
2014-05-29 14:08 ` Santosh Shilimkar
2014-05-29 19:24 ` Arnd Bergmann
2014-05-29 20:04 ` Santosh Shilimkar
2014-05-02 0:49 ` Rob Herring
2014-05-05 21:47 ` Santosh Shilimkar
2014-05-05 22:08 ` Rob Herring
2014-05-06 9:40 ` Arnd Bergmann
2014-05-06 20:44 ` Santosh Shilimkar
2014-05-07 13:24 ` Santosh Shilimkar
2014-05-02 16:54 ` Bjorn Helgaas [this message]
2014-05-02 18:59 ` Arnd Bergmann
2014-05-05 20:45 ` Bjorn Helgaas
2014-05-05 20:55 ` Arnd Bergmann
2014-05-05 22:28 ` Bjorn Helgaas
2014-05-06 3:44 ` Benjamin Herrenschmidt
2014-05-06 9:54 ` Arnd Bergmann
2014-05-06 13:32 ` Santosh Shilimkar
2014-04-24 15:30 ` [PATCH v3 5/7] ARM: dma: Use dma_pfn_offset for dma address translation Santosh Shilimkar
2014-05-02 14:32 ` Rob Herring
2014-05-02 14:58 ` Russell King - ARM Linux
2014-05-02 15:05 ` Santosh Shilimkar
2014-05-05 19:50 ` Russell King - ARM Linux
2014-05-05 21:43 ` Santosh Shilimkar
2014-04-24 15:30 ` [PATCH v3 6/7] ARM: dma: implement set_arch_dma_coherent_ops() Santosh Shilimkar
2014-05-02 0:58 ` Rob Herring
2014-04-24 15:30 ` [PATCH v3 7/7] ARM: dma: use phys_addr_t in __dma_page_[cpu_to_dev/dev_to_cpu] Santosh Shilimkar
2014-04-24 15:45 ` Will Deacon
2014-05-01 13:19 ` [PATCH v3 0/7] of: setup dma parameters using dma-ranges and dma-coherent Santosh Shilimkar
2014-05-01 13:25 ` Russell King - ARM Linux
2014-05-01 14:06 ` Santosh Shilimkar
2014-05-02 14:41 ` Rob Herring
2014-05-02 16:41 ` Santosh Shilimkar
2014-05-14 10:12 ` Grant Likely
2014-06-02 6:37 ` Shawn Guo
2014-06-02 13:24 ` Santosh Shilimkar
2014-06-02 15:06 ` Arnd Bergmann
2014-06-02 15:54 ` Santosh Shilimkar
2014-06-02 19:00 ` Arnd Bergmann
2014-06-02 19:08 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140502165459.GA29511@google.com \
--to=bhelgaas@google.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=grygorii.strashko@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).