From: Oleg Nesterov <oleg@redhat.com>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: lock_task_sighand() && rcu_boost()
Date: Mon, 5 May 2014 18:47:20 +0200 [thread overview]
Message-ID: <20140505164719.GA31758@redhat.com> (raw)
In-Reply-To: <20140505152610.GK8754@linux.vnet.ibm.com>
On 05/05, Paul E. McKenney wrote:
>
> Does the patch below cover it?
Yes, thanks.
Acked-by: Oleg Nesterov <oleg@redhat.com>
> signal: Explain local_irq_save() call
>
> The explicit local_irq_save() in __lock_task_sighand() is needed to avoid
> a potential deadlock condition, as noted in a841796f11c90d53 (signal:
> align __lock_task_sighand() irq disabling and RCU). However, someone
> reading the code might be forgiven for concluding that this separate
> local_irq_save() was completely unnecessary. This commit therefore adds
> a comment referencing the shiny new block comment on rcu_read_unlock().
>
> Reported-by: Oleg Nesterov <oleg@redhat.com>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>
> diff --git a/kernel/signal.c b/kernel/signal.c
> index 6ea13c09ae56..513e8c252aa4 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -1288,6 +1288,10 @@ struct sighand_struct *__lock_task_sighand(struct task_struct *tsk,
> struct sighand_struct *sighand;
>
> for (;;) {
> + /*
> + * Disable interrupts early to avoid deadlocks.
> + * See rcu_read_unlock comment header for details.
> + */
> local_irq_save(*flags);
> rcu_read_lock();
> sighand = rcu_dereference(tsk->sighand);
>
next prev parent reply other threads:[~2014-05-05 16:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-03 16:11 lock_task_sighand() && rcu_boost() Oleg Nesterov
2014-05-04 18:01 ` Paul E. McKenney
2014-05-04 19:17 ` Oleg Nesterov
2014-05-04 22:38 ` Paul E. McKenney
2014-05-05 13:26 ` Oleg Nesterov
2014-05-05 15:26 ` Paul E. McKenney
2014-05-05 16:47 ` Oleg Nesterov [this message]
2014-05-05 18:53 ` [PATCH] signal: Simplify __lock_task_sighand() Oleg Nesterov
2014-05-05 19:55 ` Oleg Nesterov
2014-05-05 20:56 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140505164719.GA31758@redhat.com \
--to=oleg@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).