From: Jiri Olsa <jolsa@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>,
a.p.zijlstra@chello.nl, paulus@samba.org, acme@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3] perf tools: Clarify the output of perf sched map.
Date: Tue, 6 May 2014 14:44:27 +0200 [thread overview]
Message-ID: <20140506124427.GC1079@krava.brq.redhat.com> (raw)
In-Reply-To: <20140506072304.GA25402@gmail.com>
On Tue, May 06, 2014 at 09:23:04AM +0200, Ingo Molnar wrote:
>
> * Dongsheng Yang <yangds.fnst@cn.fujitsu.com> wrote:
>
> > From: Dongsheng <yangds.fnst@cn.fujitsu.com>
> >
> > In output of perf sched map, any shortname of thread will be explained
> > at the first time when it appear.
> >
> > Example:
> > *A0 228836.978985 secs A0 => perf:23032
> > *. A0 228836.979016 secs B0 => swapper:0
> > . *C0 228836.979099 secs C0 => migration/3:22
> > *A0 . C0 228836.979115 secs
> > A0 . *. 228836.979115 secs
> >
> > But B0, which is explained as swapper:0 did not appear in the
> > left part of output. Instead, we use '.' as the shortname of
> > swapper:0. So the comment of "B0 => swapper:0" is not easy to
> > understand.
> >
> > This patch clarify the output of perf sched map with not allocating
> > one letter-number shortname for swapper:0 and print ". => swapper:0"
> > as the explaination for swapper:0.
> >
> > Example:
> > *A0 228836.978985 secs A0 => perf:23032
> > * . A0 228836.979016 secs . => swapper:0
> > . *B0 228836.979099 secs B0 => migration/3:22
> > *A0 . B0 228836.979115 secs
> > A0 . * . 228836.979115 secs
> > A0 *C0 . 228836.979225 secs C0 => ksoftirqd/2:18
> > A0 *D0 . 228836.979236 secs D0 => rcu_sched:7
> >
> > Signed-off-by: Dongsheng <yangds.fnst@cn.fujitsu.com>
> > Acked-by: Ingo Molnar <mingo@kernel.org>
>
> Looks good to me, thanks!
thanks, I'll queue this patchset
jirka
next prev parent reply other threads:[~2014-05-06 12:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 7:05 [PATCH 0/3] perf tools: Patchset for perf sched Dongsheng Yang
2014-05-05 7:05 ` [PATCH 1/3] perf tools: add missing event for perf sched record Dongsheng Yang
2014-05-12 16:00 ` [tip:perf/core] perf tools: Add " tip-bot for Dongsheng
2014-05-05 7:05 ` [PATCH 2/3] perf tools: Adapt the TASK_STATE_TO_CHAR_STR to new value in kernel space Dongsheng Yang
2014-05-12 16:00 ` [tip:perf/core] " tip-bot for Dongsheng
2014-05-05 7:05 ` [PATCH 3/3] perf tools: Clarify the output of perf sched map Dongsheng Yang
2014-05-05 18:24 ` Jiri Olsa
2014-05-05 18:27 ` David Ahern
2014-05-05 18:37 ` Ingo Molnar
2014-05-06 0:40 ` [PATCH V2] " Dongsheng Yang
2014-05-06 6:23 ` Ingo Molnar
2014-05-06 5:27 ` Dongsheng Yang
2014-05-06 5:39 ` [PATCH V3] " Dongsheng Yang
2014-05-06 7:23 ` Ingo Molnar
2014-05-06 12:44 ` Jiri Olsa [this message]
2014-05-12 16:01 ` [tip:perf/core] " tip-bot for Dongsheng
2014-05-05 18:25 ` [PATCH 0/3] perf tools: Patchset for perf sched Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140506124427.GC1079@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulus@samba.org \
--cc=yangds.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).