From: Ingo Molnar <mingo@kernel.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Igor Mammedov <imammedo@redhat.com>,
linux-kernel@vger.kernel.org, tglx@linutronix.de,
mingo@redhat.com, hpa@zytor.com, x86@kernel.org, bp@suse.de,
paul.gortmaker@windriver.com, JBeulich@suse.com,
prarit@redhat.com, drjones@redhat.com, toshi.kani@hp.com,
riel@redhat.com, gong.chen@linux.intel.com, andi@firstfloor.org,
lenb@kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH v5 2/4] acpi_processor: do not mark present at boot but not onlined CPU as onlined
Date: Thu, 8 May 2014 13:17:30 +0200 [thread overview]
Message-ID: <20140508111730.GA5074@gmail.com> (raw)
In-Reply-To: <2022136.gFLGQmut0v@vostro.rjw.lan>
* Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> On Thursday, May 08, 2014 08:09:35 AM Ingo Molnar wrote:
> >
> > * Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> >
> > > On Monday, May 05, 2014 10:49:49 PM Igor Mammedov wrote:
> > > > acpi_processor_add() assumes that present at boot CPUs
> > > > are always onlined, it is not so if a CPU failed to become
> > > > onlined. As result acpi_processor_add() will mark such CPU
> > > > device as onlined in sysfs and following attempts to
> > > > online/offline it using /sys/device/system/cpu/cpuX/online
> > > > attribute will fail.
> > > >
> > > > Do not poke into device internals in acpi_processor_add()
> > > > and touch "struct device { .offline }" attribute, since
> > > > for CPUs onlined at boot it's set by:
> > > > topology_init() -> arch_register_cpu() -> register_cpu()
> > > > before ACPI device tree is parsed, and for hotplugged
> > > > CPUs it's set when userspace onlines CPU via sysfs.
> > > >
> > > > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > > > Acked-by: Toshi Kani <toshi.kani@hp.com>
> > >
> > > Would there be a problem if I applied this separately from the rest
> > > of the series?
> >
> > If you push the fix upstream for v3.15 then it would be fine and I
> > could base the other patches on top of your (soon to be upstream)
> > commit.
>
> OK, I can do that.
>
> We also seem to need this in -stable, right?
Yeah, agreed.
Thanks,
Ingo
next prev parent reply other threads:[~2014-05-08 11:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 20:49 [PATCH v5 0/4] x86: fix hang when AP bringup is too slow Igor Mammedov
2014-05-05 20:49 ` [PATCH v5 1/4] x86: fix list/memory corruption on CPU hotplug Igor Mammedov
2014-05-05 20:49 ` [PATCH v5 2/4] acpi_processor: do not mark present at boot but not onlined CPU as onlined Igor Mammedov
2014-05-07 23:48 ` Rafael J. Wysocki
2014-05-08 6:09 ` Ingo Molnar
2014-05-08 11:33 ` Rafael J. Wysocki
2014-05-08 11:17 ` Ingo Molnar [this message]
2014-05-05 20:49 ` [PATCH v5 3/4] x86: log error on secondary CPU wakeup failure at ERR level Igor Mammedov
2014-05-05 20:49 ` [PATCH v5 4/4] x86: initialize secondary CPU only if master CPU will wait for it Igor Mammedov
2014-05-05 21:35 ` Toshi Kani
2014-06-04 13:21 ` [PATCH v5 0/4] x86: fix hang when AP bringup is too slow Igor Mammedov
2014-06-05 12:29 ` Ingo Molnar
2014-06-05 13:12 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140508111730.GA5074@gmail.com \
--to=mingo@kernel.org \
--cc=JBeulich@suse.com \
--cc=andi@firstfloor.org \
--cc=bp@suse.de \
--cc=drjones@redhat.com \
--cc=gong.chen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=imammedo@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paul.gortmaker@windriver.com \
--cc=prarit@redhat.com \
--cc=riel@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=toshi.kani@hp.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).