linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Andres Freund <andres@anarazel.de>
Cc: Borislav Petkov <bp@suse.de>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	"H. Peter Anvin" <hpa@linux.intel.com>,
	Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 2/2] x86: Fix typo in MSR_IA32_MISC_ENABLE_LIMIT_CPUID macro
Date: Fri, 9 May 2014 09:57:30 +0200	[thread overview]
Message-ID: <20140509075730.GB16058@pd.tnic> (raw)
In-Reply-To: <1399598957-7011-3-git-send-email-andres@anarazel.de>

On Fri, May 09, 2014 at 03:29:17AM +0200, Andres Freund wrote:
> The spuriously added semicolon didn't have any effect because the
> macro isn't currently in use.
> 
> c0a639ad0bc6b178b46996bd1f821a04643e2bde
> 
> Signed-off-by: Andres Freund <andres@anarazel.de>
> Cc: Borislav Petkov <bp@suse.de>
> Cc: H. Peter Anvin <hpa@linux.intel.com>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> ---
>  arch/x86/include/uapi/asm/msr-index.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/include/uapi/asm/msr-index.h b/arch/x86/include/uapi/asm/msr-index.h
> index c827ace..fcf2b3a 100644
> --- a/arch/x86/include/uapi/asm/msr-index.h
> +++ b/arch/x86/include/uapi/asm/msr-index.h
> @@ -384,7 +384,7 @@
>  #define MSR_IA32_MISC_ENABLE_MWAIT_BIT			18
>  #define MSR_IA32_MISC_ENABLE_MWAIT			(1ULL << MSR_IA32_MISC_ENABLE_MWAIT_BIT)
>  #define MSR_IA32_MISC_ENABLE_LIMIT_CPUID_BIT		22
> -#define MSR_IA32_MISC_ENABLE_LIMIT_CPUID		(1ULL << MSR_IA32_MISC_ENABLE_LIMIT_CPUID_BIT);
> +#define MSR_IA32_MISC_ENABLE_LIMIT_CPUID		(1ULL << MSR_IA32_MISC_ENABLE_LIMIT_CPUID_BIT)
>  #define MSR_IA32_MISC_ENABLE_XTPR_DISABLE_BIT		23
>  #define MSR_IA32_MISC_ENABLE_XTPR_DISABLE		(1ULL << MSR_IA32_MISC_ENABLE_XTPR_DISABLE_BIT)
>  #define MSR_IA32_MISC_ENABLE_XD_DISABLE_BIT		34

Acked-by: Borislav Petkov <bp@suse.de>

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--

  reply	other threads:[~2014-05-09  7:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-09  1:29 Andres Freund
2014-05-09  1:29 ` [PATCH 1/2] x86: Fix typo preventing msr_set/clear_bit from having an effect Andres Freund
2014-05-09  7:54   ` Borislav Petkov
2014-05-09 10:39     ` Andres Freund
2014-05-09 10:46       ` Borislav Petkov
2014-05-09 16:31   ` [tip:x86/urgent] x86: Fix typo preventing msr_set/ clear_bit " tip-bot for Andres Freund
2014-05-09  1:29 ` [PATCH 2/2] x86: Fix typo in MSR_IA32_MISC_ENABLE_LIMIT_CPUID macro Andres Freund
2014-05-09  7:57   ` Borislav Petkov [this message]
2014-05-09 10:33     ` Borislav Petkov
2014-05-09 17:02       ` Joe Perches
2014-05-09 21:31       ` [PATCH] checkpatch: Warn on #defines ending in semicolon Joe Perches
2014-05-09 21:47         ` Thomas Gleixner
2014-05-09 21:59           ` Joe Perches
2014-05-09 16:31   ` [tip:x86/urgent] x86: Fix typo in MSR_IA32_MISC_ENABLE_LIMIT_CPUID macro tip-bot for Andres Freund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140509075730.GB16058@pd.tnic \
    --to=bp@alien8.de \
    --cc=andres@anarazel.de \
    --cc=bp@suse.de \
    --cc=hpa@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).