From: Mark Brown <broonie@kernel.org>
To: Naveen Krishna Ch <naveenkrishna.ch@gmail.com>
Cc: Naveen Krishna Chatradhi <ch.naveen@samsung.com>,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
sjg@chromium.org, grundler@chromium.org,
linux-kernel@vger.kernel.org, wsa@the-dreams.de,
cpgs@samsung.com
Subject: Re: [PATCH] i2c: exynos5: Initialise Samsung High Speed I2C controller early
Date: Fri, 9 May 2014 14:51:53 +0100 [thread overview]
Message-ID: <20140509135153.GM12304@sirena.org.uk> (raw)
In-Reply-To: <CAHfPSqB5+mLiC07jbEpeUgW63pZVk700SkYGxToO7GRAsFm_nQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1452 bytes --]
On Fri, May 09, 2014 at 05:50:00PM +0530, Naveen Krishna Ch wrote:
> On 24 April 2014 21:55, Mark Brown <broonie@kernel.org> wrote:
> >> Such solution has been proposed by Mark Brown to fix the problem of
> >> the regulators not beeing available on the peripheral device probe():
> >> http://lists.infradead.org/pipermail/linux-arm-kernel/2010-March/011971.html
> > What specifically is this needed for? We *should* be able to use
> > deferred probe for most things, but I know that not all subsystems are
> > able to yet.
> DRM related drivers like DP, FIMD, HDMI, Mixer wants to be probed ASAP
> during the boot.
> The real problem comes when, one of these drivers do a regulator_get().
> If the physical supply is not enabled/hookedup the regulator_get() call
> assumes that physical supply is present and returns a
> "dummy_regulator" (But, not an error).
> Because of which, Display and several other devices fails to work.
These drivers are buggy, if they geniunely expect and handle a missing
supply then they should be using regulator_get_optional() to request the
regulator and even if they don't the use of subsys_initcall() is not
going to fix anything here - if a dummy regulator is going to be
returned the time things are probed won't make a difference.
> I2C, I2C_TUNNEL, SPI and DMA drivers are required as subsys_initcall()
> for similar reason.
What makes you say this? Typically those drivers don't use regulators
at all.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-05-09 13:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 14:48 [PATCH] i2c: exynos5: Initialise Samsung High Speed I2C controller early Naveen Krishna Chatradhi
2014-04-24 16:25 ` Mark Brown
2014-04-25 4:58 ` Tushar Behera
2014-05-09 12:20 ` Naveen Krishna Ch
2014-05-09 13:51 ` Mark Brown [this message]
2014-05-09 14:42 ` Naveen Krishna Ch
2014-05-09 14:54 ` Mark Brown
2014-05-21 10:25 ` Wolfram Sang
2014-05-21 12:04 ` Naveen Krishna Ch
2014-05-21 13:00 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140509135153.GM12304@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ch.naveen@samsung.com \
--cc=cpgs@samsung.com \
--cc=grundler@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=naveenkrishna.ch@gmail.com \
--cc=sjg@chromium.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).