From: Fabian Frederick <fabf@skynet.be>
To: linux-kernel <linux-kernel@vger.kernel.org>
Cc: Joel Becker <jlbec@evilplan.org>, Joe Perches <joe@perches.com>,
akpm <akpm@linux-foundation.org>
Subject: [RFC 1/1] fs/configfs/dir.c: remove unused debugging functions
Date: Tue, 13 May 2014 20:38:32 +0200 [thread overview]
Message-ID: <20140513203832.cb793ce47b8af993f561e5c2@skynet.be> (raw)
Joe Perches noticed it was not used anywhere.
If there's no plan to use it in the future,
we could simply remove both functions ...
Cc: Joe Perches <joe@perches.com>
Cc: Joel Becker <jlbec@evilplan.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
fs/configfs/dir.c | 37 -------------------------------------
1 file changed, 37 deletions(-)
diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c
index e081acb..1b12d0a 100644
--- a/fs/configfs/dir.c
+++ b/fs/configfs/dir.c
@@ -937,43 +937,6 @@ static void client_drop_item(struct config_item *parent_item,
config_item_put(item);
}
-#ifdef DEBUG
-static void configfs_dump_one(struct configfs_dirent *sd, int level)
-{
- printk(KERN_INFO "%*s\"%s\":\n", level, " ", configfs_get_name(sd));
-
-#define type_print(_type) if (sd->s_type & _type) printk(KERN_INFO "%*s %s\n", level, " ", #_type);
- type_print(CONFIGFS_ROOT);
- type_print(CONFIGFS_DIR);
- type_print(CONFIGFS_ITEM_ATTR);
- type_print(CONFIGFS_ITEM_LINK);
- type_print(CONFIGFS_USET_DIR);
- type_print(CONFIGFS_USET_DEFAULT);
- type_print(CONFIGFS_USET_DROPPING);
-#undef type_print
-}
-
-static int configfs_dump(struct configfs_dirent *sd, int level)
-{
- struct configfs_dirent *child_sd;
- int ret = 0;
-
- configfs_dump_one(sd, level);
-
- if (!(sd->s_type & (CONFIGFS_DIR|CONFIGFS_ROOT)))
- return 0;
-
- list_for_each_entry(child_sd, &sd->s_children, s_sibling) {
- ret = configfs_dump(child_sd, level + 2);
- if (ret)
- break;
- }
-
- return ret;
-}
-#endif
-
-
/*
* configfs_depend_item() and configfs_undepend_item()
*
--
1.8.4.5
next reply other threads:[~2014-05-13 18:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 18:38 Fabian Frederick [this message]
2014-06-25 12:56 ` [RFC 1/1] fs/configfs/dir.c: remove unused debugging functions Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140513203832.cb793ce47b8af993f561e5c2@skynet.be \
--to=fabf@skynet.be \
--cc=akpm@linux-foundation.org \
--cc=jlbec@evilplan.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).