From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751797AbaENT4E (ORCPT ); Wed, 14 May 2014 15:56:04 -0400 Received: from asavdk4.altibox.net ([109.247.116.15]:60658 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750834AbaENT4B (ORCPT ); Wed, 14 May 2014 15:56:01 -0400 Date: Wed, 14 May 2014 21:55:55 +0200 From: Sam Ravnborg To: Richard Weinberger Cc: linux-arch@vger.kernel.org, arnd@arndb.de, linux-kernel@vger.kernel.org, "David S. Miller" , sparclinux@vger.kernel.org Subject: Re: [PATCH 23/27] sparc: Use common bits from generic tlb.h Message-ID: <20140514195555.GA2801@ravnborg.org> References: <1400093999-18703-1-git-send-email-richard@nod.at> <1400093999-18703-24-git-send-email-richard@nod.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1400093999-18703-24-git-send-email-richard@nod.at> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 14, 2014 at 08:59:55PM +0200, Richard Weinberger wrote: > It is no longer needed to define them on our own. > > Cc: "David S. Miller" > Cc: Richard Weinberger > Cc: sparclinux@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Richard Weinberger > --- > arch/sparc/include/asm/tlb_32.h | 8 -------- > arch/sparc/include/asm/tlb_64.h | 3 --- > 2 files changed, 11 deletions(-) > > diff --git a/arch/sparc/include/asm/tlb_32.h b/arch/sparc/include/asm/tlb_32.h > index 6d02d1c..60641a1 100644 > --- a/arch/sparc/include/asm/tlb_32.h > +++ b/arch/sparc/include/asm/tlb_32.h > @@ -11,14 +11,6 @@ do { \ > flush_tlb_range(vma, vma->vm_start, vma->vm_end); \ > } while (0) > > -#define __tlb_remove_tlb_entry(tlb, pte, address) \ > - do { } while (0) > - > -#define tlb_flush(tlb) \ > -do { \ > - flush_tlb_mm((tlb)->mm); \ > -} while (0) > - > #include > > #endif /* _SPARC_TLB_H */ This part looks OK. > diff --git a/arch/sparc/include/asm/tlb_64.h b/arch/sparc/include/asm/tlb_64.h > index 190e189..36fdcec 100644 > --- a/arch/sparc/include/asm/tlb_64.h > +++ b/arch/sparc/include/asm/tlb_64.h > @@ -22,9 +22,6 @@ extern void smp_flush_tlb_mm(struct mm_struct *mm); > extern void __flush_tlb_pending(unsigned long, unsigned long, unsigned long *); > extern void flush_tlb_pending(void); > > -#define tlb_start_vma(tlb, vma) do { } while (0) > -#define tlb_end_vma(tlb, vma) do { } while (0) > -#define __tlb_remove_tlb_entry(tlb, ptep, address) do { } while (0) > #define tlb_flush(tlb) flush_tlb_pending() > > #include This does not fly for sparc64. __pte_free_tlb is a static inline in pgalloc_64.h so no define exist to teach tlb.h that an arch override exist. Likewise for __pmd_free_tlb Sam