From: Thierry Reding <thierry.reding@gmail.com>
To: Rahul Sharma <rahul.sharma@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
dri-devel@lists.freedesktop.org, a.hajda@samsung.com,
t.stanislaws@samsung.com, devicetree@vger.kernel.org,
kgene.kim@samsung.com, kishon@ti.com, kyungmin.park@samsung.com,
robh+dt@kernel.org, grant.likely@linaro.org,
sylvester.nawrocki@gmail.com, joshi@samsung.com
Subject: Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver
Date: Thu, 15 May 2014 00:14:25 +0200 [thread overview]
Message-ID: <20140514221423.GC6215@mithrandir> (raw)
In-Reply-To: <1400095043-685-2-git-send-email-rahul.sharma@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 2447 bytes --]
On Thu, May 15, 2014 at 12:47:21AM +0530, Rahul Sharma wrote:
[...]
> diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt b/Documentation/devicetree/bindings/phy/samsung-phy.txt
[...]
> +For "samsung,exynos4210-simple-phy" compatible PHYs the second cell in
> +the PHY specifier identifies the PHY and the supported phys for exynos4210
I think the specifier is only the part after the phandle, so this should
probably be "... compatible PHYs the single cell specifier ..." or
something equivalent.
> +are:
> + HDMI_PHY,
> + DAC_PHY,
> + ADC_PHY,
> + PCIE_PHY,
> + SATA_PHY.
I think you need to specify the literal values here as well, since the
binding must be fully self-contained. That is you can't rely on the DT
binding to be bundled with the exynos-simple-phy.h header.
> @@ -20,3 +20,4 @@ phy-exynos-usb2-$(CONFIG_PHY_EXYNOS4X12_USB2) += phy-exynos4x12-usb2.o
> phy-exynos-usb2-$(CONFIG_PHY_EXYNOS5250_USB2) += phy-exynos5250-usb2.o
> obj-$(CONFIG_PHY_EXYNOS5_USBDRD) += phy-exynos5-usbdrd.o
> obj-$(CONFIG_PHY_XGENE) += phy-xgene.o
> +obj-$(CONFIG_EXYNOS_SIMPLE_PHY) += exynos-simple-phy.o
Perhaps this should be named phy-exynos-simple for consistency? Also it
may be a good idea to sort this alphabetically to reduce the potential
for conflicts.
> +static int exynos_phy_probe(struct platform_device *pdev)
> +{
> + const struct of_device_id *of_id = of_match_device(
> + of_match_ptr(exynos_phy_of_match), &pdev->dev);
Why does this need of_match_ptr()?
> + dev_info(dev, "probe success\n");
If at all this should be dev_dbg(). But in general the driver core will
already complain if the driver fails to probe, so there's in general no
need to mention when it probes successfully.
> diff --git a/include/dt-bindings/phy/exynos-simple-phy.h b/include/dt-bindings/phy/exynos-simple-phy.h
[...]
> +/* simeple phys */
s/simeple phys/simple PHYs/
Although on second thought that comment probably shouldn't be there in
the first place.
> +#define INVALID (~1)
This doesn't belong in this header. The value should never be used by a
DT source file, should it?
> +#define HDMI_PHY 0
> +#define DAC_PHY 1
> +#define ADC_PHY 2
> +#define PCIE_PHY 3
> +#define SATA_PHY 4
Perhaps these should be namespaced somehow to avoid potential conflicts
with other PHY providers?
> +#define PHY_NR 5
I'm not sure that this belongs here either. It's not a value that will
ever appear in a DT source file.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-05-14 22:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 19:17 [PATCH v3 0/3] phy: Add exynos-simple-phy driver Rahul Sharma
2014-05-14 19:17 ` [PATCH v3 1/3] " Rahul Sharma
2014-05-14 20:01 ` Tomasz Figa
2014-05-15 4:01 ` Rahul Sharma
2014-05-15 21:44 ` Tomasz Figa
2014-05-16 9:42 ` Rahul Sharma
2014-05-16 10:35 ` Rahul Sharma
2014-05-16 10:50 ` Tomasz Figa
2014-05-16 14:30 ` Rahul Sharma
2014-05-16 14:49 ` Tomasz Figa
2014-05-19 7:10 ` Rahul Sharma
2014-05-19 10:54 ` Tomasz Figa
2014-05-20 5:12 ` Rahul Sharma
2014-05-14 22:14 ` Thierry Reding [this message]
2014-05-15 5:19 ` Rahul Sharma
2014-05-15 7:42 ` Thierry Reding
2014-05-15 8:17 ` Rahul Sharma
2014-05-15 9:23 ` Thierry Reding
2014-05-15 13:31 ` Bartlomiej Zolnierkiewicz
2014-05-15 13:35 ` Rahul Sharma
2014-05-15 13:41 ` Kishon Vijay Abraham I
2014-05-15 13:45 ` Rahul Sharma
2014-05-14 19:17 ` [PATCH v3 2/3] drm: exynos: hdmi: use hdmiphy as PHY Rahul Sharma
2014-05-14 19:17 ` [PATCH v3 3/3] s5p-tv: " Rahul Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140514221423.GC6215@mithrandir \
--to=thierry.reding@gmail.com \
--cc=a.hajda@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=grant.likely@linaro.org \
--cc=joshi@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kishon@ti.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rahul.sharma@samsung.com \
--cc=robh+dt@kernel.org \
--cc=sylvester.nawrocki@gmail.com \
--cc=t.stanislaws@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).