From: "George Spelvin" <linux@horizon.com>
To: hpa@zytor.com, linux@horizon.com, pavel@ucw.cz
Cc: arik@wizery.com, david.gnedt@davizone.at, eliad@wizery.com,
jan.nikitenko@gmail.com,
laurent.pinchart+renesas@ideasonboard.com,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-spi@vger.kernel.org, linux-wireless@vger.kernel.org,
linville@tuxdriver.com, luca@coelho.fi, tony@atomide.com
Subject: Re: [PATCH v2 1/3] lib/crc7: Shift crc7() output left 1 bit
Date: 14 May 2014 22:02:38 -0400 [thread overview]
Message-ID: <20140515020238.32013.qmail@ns.horizon.com> (raw)
In-Reply-To: <2e076c13-84aa-4da4-a443-7e8fcc462fc9@email.android.com>
H. Peter Anvin wrote:
> Seems to me to make the code easier to read, not harder. That was the
> whole point.
I thought it made it harder by moving the terminating 1 bit out of the
driver proper, where it has a symbolic name. Thus someone comparing
the driver to the spec has to read another source file to figure out
how the driver gets that bit set.
As it is, the straight-line code in the driver corresponds very simply
with the packet as illustrated in the data sheets.
I agree it's really really minor either way, but so is the saving
we're going for.
Since it's not *clearly* an improvement, I err on the side of not
messing with a driver I can't test.
prev parent reply other threads:[~2014-05-15 2:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-11 4:35 [PATCH] lib/crc7: Shift crc7() output left 1 bit George Spelvin
2014-05-11 8:28 ` Pavel Machek
2014-05-11 9:16 ` George Spelvin
2014-05-14 19:56 ` Pavel Machek
2014-05-15 0:32 ` George Spelvin
2014-05-15 6:06 ` Pavel Machek
2014-05-11 10:02 ` [PATCH v2 1/3] " George Spelvin
2014-05-11 10:05 ` [PATCH 2/3] drivers/mmc/host/mmc_spi.c: Use get/put_unaligned_be32 George Spelvin
2014-05-11 10:33 ` Pavel Machek
2014-05-12 8:05 ` Geert Uytterhoeven
2014-05-14 10:17 ` Ulf Hansson
2014-05-14 12:23 ` George Spelvin
2014-05-14 12:30 ` Ulf Hansson
2014-05-14 14:50 ` John W. Linville
2014-05-11 10:07 ` [PATCH 3/3] drivers/net/wireless/ti/wl*/spi.c: Simplify CRC computation George Spelvin
2014-05-11 10:36 ` Pavel Machek
2014-05-11 10:32 ` [PATCH v2 1/3] lib/crc7: Shift crc7() output left 1 bit Pavel Machek
2014-05-14 10:14 ` Ulf Hansson
2014-05-15 0:37 ` H. Peter Anvin
2014-05-15 1:15 ` George Spelvin
2014-05-15 1:26 ` H. Peter Anvin
2014-05-15 2:02 ` George Spelvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140515020238.32013.qmail@ns.horizon.com \
--to=linux@horizon.com \
--cc=arik@wizery.com \
--cc=david.gnedt@davizone.at \
--cc=eliad@wizery.com \
--cc=hpa@zytor.com \
--cc=jan.nikitenko@gmail.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=luca@coelho.fi \
--cc=pavel@ucw.cz \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).