From: Thierry Reding <thierry.reding@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andrew Bresticker <abrestic@chromium.org>,
linux-tegra@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Russell King <linux@arm.linux.org.uk>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
Prashant Gaikwad <pgaikwad@nvidia.com>,
Mike Turquette <mturquette@linaro.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mathias Nyman <mathias.nyman@intel.com>,
Grant Likely <grant.likely@linaro.org>,
Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [RFC PATCH 06/10] usb: xhci: Add Tegra XHCI host-controller driver
Date: Thu, 15 May 2014 11:19:40 +0200 [thread overview]
Message-ID: <20140515091938.GD6434@ulmo> (raw)
In-Reply-To: <15599140.PsD4j7x3tZ@wuerfel>
[-- Attachment #1: Type: text/plain, Size: 1570 bytes --]
On Thu, May 15, 2014 at 10:17:10AM +0200, Arnd Bergmann wrote:
> On Wednesday 14 May 2014 17:33:02 Andrew Bresticker wrote:
[...]
> > + /* Create child xhci-plat device */
> > + memset(xhci_resources, 0, sizeof(xhci_resources));
> > + res = platform_get_resource(to_platform_device(dev), IORESOURCE_IRQ, 0);
> > + if (!res) {
> > + dev_err(dev, "Missing XHCI IRQ\n");
> > + ret = -ENODEV;
> > + goto out;
> > + }
> > + xhci_resources[0].start = res->start;
> > + xhci_resources[0].end = res->end;
> > + xhci_resources[0].flags = res->flags;
> > + xhci_resources[0].name = res->name;
> > + res = platform_get_resource(to_platform_device(dev), IORESOURCE_MEM, 0);
> > + if (!res) {
> > + dev_err(dev, "Missing XHCI registers\n");
> > + ret = -ENODEV;
> > + goto out;
> > + }
> > + xhci_resources[1].start = res->start;
> > + xhci_resources[1].end = res->end;
> > + xhci_resources[1].flags = res->flags;
> > + xhci_resources[1].name = res->name;
> > +
> > + xhci = platform_device_alloc("xhci-hcd", PLATFORM_DEVID_AUTO);
> > + if (!xhci) {
> > + dev_err(dev, "Failed to allocate XHCI host\n");
> > + ret = -ENOMEM;
> > + goto out;
> > + }
>
> This does not feel appropriate at all: Rather than creating a child device,
> you should have a specific driver that hooks into functions exported
> by the xhci core. See Documentation/driver-model/design-patterns.txt
I don't think Documentation/driver-model/design-patterns.txt documents
this. Perhaps this is what you had in mind?
http://lwn.net/Articles/336262/
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-05-15 9:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-15 0:32 [RFC PATCH 00/10] Tegra XHCI support Andrew Bresticker
2014-05-15 0:32 ` [RFC PATCH 01/10] clk: tegra: Enable hardware control of PLLE Andrew Bresticker
2014-05-15 0:32 ` [RFC PATCH 02/10] clk: tegra: Fix xusb_fs_src mux Andrew Bresticker
2014-05-15 0:32 ` [RFC PATCH 03/10] clk: tegra: Fix xusb_hs_src clock hierarchy Andrew Bresticker
2014-05-15 0:33 ` [RFC PATCH 04/10] clk: tegra: Initialize xusb clocks Andrew Bresticker
2014-05-15 19:22 ` Stephen Warren
2014-05-20 15:41 ` Peter De Schrijver
2014-05-15 0:33 ` [RFC PATCH 05/10] ARM: tegra: Export function to read USB calibration data Andrew Bresticker
2014-05-15 20:39 ` Stephen Warren
2014-05-15 0:33 ` [RFC PATCH 06/10] usb: xhci: Add Tegra XHCI host-controller driver Andrew Bresticker
2014-05-15 8:17 ` Arnd Bergmann
2014-05-15 9:19 ` Thierry Reding [this message]
2014-05-15 13:30 ` Arnd Bergmann
2014-05-15 20:18 ` Andrew Bresticker
2014-05-15 21:16 ` Alan Stern
2014-05-15 21:18 ` Thierry Reding
2014-05-16 16:52 ` Andrew Bresticker
2014-05-15 0:33 ` [RFC PATCH 07/10] phy: Add Tegra XUSB PHY driver Andrew Bresticker
2014-05-15 0:33 ` [RFC PATCH 08/10] ARM: tegra124: Bind CAR to syscon device Andrew Bresticker
2014-05-15 19:25 ` Stephen Warren
2014-05-15 20:22 ` Andrew Bresticker
2014-05-15 0:33 ` [RFC PATCH 09/10] ARM: tegra124: Add XHCI controller and PHY Andrew Bresticker
2014-05-15 0:33 ` [RFC PATCH 10/10] ARM: tegra124: Enable XHCI on Venice2 Andrew Bresticker
2014-05-15 19:33 ` [RFC PATCH 00/10] Tegra XHCI support Stephen Warren
2014-05-15 20:44 ` Andrew Bresticker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140515091938.GD6434@ulmo \
--to=thierry.reding@gmail.com \
--cc=abrestic@chromium.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mathias.nyman@intel.com \
--cc=mturquette@linaro.org \
--cc=pawel.moll@arm.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).