From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Robert Richter <rric@kernel.org>,
kernel-janitors@vger.kernel.org,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux390@de.ibm.com, oprofile-list@lists.sf.net,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 13/13] s390/irq: make return of 0 explicit
Date: Mon, 19 May 2014 08:03:18 +0200 [thread overview]
Message-ID: <20140519060318.GA4459@osiris> (raw)
In-Reply-To: <1400473875-22228-14-git-send-email-Julia.Lawall@lip6.fr>
On Mon, May 19, 2014 at 06:31:15AM +0200, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Delete unnecessary local variable whose value is always 0 and that hides
> the fact that the result is always 0.
>
> A simplified version of the semantic patch that fixes this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> arch/s390/oprofile/hwsampler.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/s390/oprofile/hwsampler.c b/arch/s390/oprofile/hwsampler.c
> index 276f2e2..28b2760 100644
> --- a/arch/s390/oprofile/hwsampler.c
> +++ b/arch/s390/oprofile/hwsampler.c
> @@ -212,10 +212,8 @@ static void init_all_cpu_buffers(void)
> static int prepare_cpu_buffers(void)
> {
> int cpu;
> - int rc;
> struct hws_cpu_buffer *cb;
>
> - rc = 0;
> for_each_online_cpu(cpu) {
> cb = &per_cpu(sampler_cpu_buffer, cpu);
> atomic_set(&cb->ext_params, 0);
> @@ -231,7 +229,7 @@ static int prepare_cpu_buffers(void)
> cb->stop_mode = 0;
> }
>
> - return rc;
> + return 0;
> }
Thanks Julia,
I applied a slightly different version which also turns prepare_cpu_buffers
into a void returning function.
prev parent reply other threads:[~2014-05-19 6:03 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 4:31 [PATCH 0/13] make return of 0 explicit Julia Lawall
2014-05-19 4:31 ` [PATCH 1/13] libertas: " Julia Lawall
2014-05-19 7:43 ` walter harms
2014-05-19 12:45 ` Sergei Shtylyov
2014-05-19 17:25 ` Dan Williams
2014-05-22 12:32 ` [PATCH] libertas: fix return value when processing invalid packet Dan Williams
2014-05-22 21:57 ` James Cameron
2014-05-20 0:30 ` [PATCH 1/13] libertas: make return of 0 explicit Julia Lawall
2014-05-20 0:36 ` Julia Lawall
2014-05-19 4:31 ` [PATCH 3/13] CLK: TI: DRA7: " Julia Lawall
2014-05-19 7:41 ` Dan Carpenter
2014-05-19 8:08 ` Tero Kristo
2014-05-19 11:25 ` [PATCH] CLK: TI: DRA7: return error code in failure case Julia Lawall
2014-05-19 12:23 ` Tero Kristo
2014-05-28 21:47 ` Mike Turquette
2014-06-19 11:24 ` Tero Kristo
2014-05-19 4:31 ` [PATCH 4/13] wimax/i2400m: make return of 0 explicit Julia Lawall
2014-05-19 7:47 ` walter harms
2014-05-19 11:30 ` Julia Lawall
2014-05-19 13:22 ` walter harms
2014-05-19 12:46 ` Sergei Shtylyov
2014-05-20 0:44 ` [PATCH 4/13 v2] " Julia Lawall
2014-05-21 21:19 ` David Miller
2014-05-19 4:31 ` [PATCH 5/13] usb: gadget: " Julia Lawall
2014-05-19 4:31 ` [PATCH 6/13] [NETFILTER]: arp_tables: " Julia Lawall
2014-05-19 4:31 ` [PATCH 7/13] staging: wlags49_h2: " Julia Lawall
2014-05-19 4:31 ` [PATCH 8/13] sound: mpu401.c: " Julia Lawall
2014-05-19 8:11 ` Takashi Iwai
2014-05-19 4:31 ` [PATCH 9/13] md: " Julia Lawall
2014-05-20 5:45 ` NeilBrown
2014-05-19 4:31 ` [PATCH 10/13] staging: rtl8192e: " Julia Lawall
2014-05-19 4:31 ` [PATCH 11/13] ufs: " Julia Lawall
2014-05-19 4:31 ` [PATCH 12/13] brcmsmac: " Julia Lawall
2014-05-19 4:31 ` [PATCH 13/13] s390/irq: " Julia Lawall
2014-05-19 6:03 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140519060318.GA4459@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=Julia.Lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=oprofile-list@lists.sf.net \
--cc=rric@kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).