From: "David Härdeman" <david@hardeman.nu>
To: Alexander Bersenev <bay@hackerdom.ru>
Cc: linux-sunxi@googlegroups.com, devicetree@vger.kernel.org,
galak@codeaurora.org, grant.likely@linaro.org,
ijc+devicetree@hellion.org.uk, james.hogan@imgtec.com,
linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk,
m.chehab@samsung.com, mark.rutland@arm.com,
maxime.ripard@free-electrons.com, pawel.moll@arm.com,
rdunlap@infradead.org, robh+dt@kernel.org, sean@mess.org,
srinivas.kandagatla@st.com, wingrime@linux-sunxi.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v7 2/3] [media] rc: add sunxi-ir driver
Date: Mon, 19 May 2014 22:26:16 +0200 [thread overview]
Message-ID: <20140519202616.GA25415@hardeman.nu> (raw)
In-Reply-To: <1400104602-16431-3-git-send-email-bay@hackerdom.ru>
On Thu, May 15, 2014 at 03:56:41AM +0600, Alexander Bersenev wrote:
>This patch adds driver for sunxi IR controller.
>It is based on Alexsey Shestacov's work based on the original driver
>supplied by Allwinner.
>
...
>+static irqreturn_t sunxi_ir_irq(int irqno, void *dev_id)
>+{
>+ unsigned long status;
>+ unsigned char dt;
>+ unsigned int cnt, rc;
>+ struct sunxi_ir *ir = dev_id;
>+ DEFINE_IR_RAW_EVENT(rawir);
>+
>+ spin_lock(&ir->ir_lock);
>+
>+ status = readl(ir->base + SUNXI_IR_RXSTA_REG);
>+
>+ /* clean all pending statuses */
>+ writel(status | REG_RXSTA_CLEARALL, ir->base + SUNXI_IR_RXSTA_REG);
>+
>+ if (status & REG_RXINT_RAI_EN) {
>+ /* How many messages in fifo */
>+ rc = (status >> REG_RXSTA_RAC__SHIFT) & REG_RXSTA_RAC__MASK;
>+ /* Sanity check */
>+ rc = rc > SUNXI_IR_FIFO_SIZE ? SUNXI_IR_FIFO_SIZE : rc;
>+ /* If we have data */
>+ for (cnt = 0; cnt < rc; cnt++) {
>+ /* for each bit in fifo */
>+ dt = readb(ir->base + SUNXI_IR_RXFIFO_REG);
>+ rawir.pulse = (dt & 0x80) != 0;
>+ rawir.duration = (dt & 0x7f) * SUNXI_IR_SAMPLE;
Can the hardware actually return a zero duration or should that be dt &
0x7f + 1?
(Not familiar with this particular hardware but I know I've seen that
behaviour before).
>+ ir_raw_event_store_with_filter(ir->rc, &rawir);
>+ }
>+ }
>+
>+ if (status & REG_RXINT_ROI_EN) {
>+ ir_raw_event_reset(ir->rc);
>+ } else if (status & REG_RXINT_RPEI_EN) {
>+ ir_raw_event_set_idle(ir->rc, true);
>+ ir_raw_event_handle(ir->rc);
>+ }
>+
>+ spin_unlock(&ir->ir_lock);
>+
>+ return IRQ_HANDLED;
>+}
....
next prev parent reply other threads:[~2014-05-19 20:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 21:56 [PATCH v7 0/3] ARM: sunxi: Add support for consumer infrared devices Alexander Bersenev
2014-05-14 21:56 ` [PATCH v7 1/3] ARM: sunxi: Add documentation for sunxi " Alexander Bersenev
2014-05-14 21:56 ` [PATCH v7 2/3] [media] rc: add sunxi-ir driver Alexander Bersenev
2014-05-15 7:24 ` Maxime Ripard
2014-05-19 8:17 ` Maxime Ripard
2014-05-19 20:26 ` David Härdeman [this message]
2014-05-14 21:56 ` [PATCH v7 3/3] ARM: sunxi: Add IR controller support in DT on A20 Alexander Bersenev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140519202616.GA25415@hardeman.nu \
--to=david@hardeman.nu \
--cc=bay@hackerdom.ru \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=james.hogan@imgtec.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux@arm.linux.org.uk \
--cc=m.chehab@samsung.com \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=pawel.moll@arm.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=sean@mess.org \
--cc=srinivas.kandagatla@st.com \
--cc=wingrime@linux-sunxi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).