linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Zhang Rui <rui.zhang@intel.com>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	bhelgaas@google.com, matthew.garrett@nebula.com,
	rafael.j.wysocki@intel.com, dmitry.torokhov@gmail.com
Subject: Re: [PATCH V6 10/11] ACPI: use platform bus as the default bus for _HID enumeration
Date: Thu, 22 May 2014 12:58:23 +0300	[thread overview]
Message-ID: <20140522095823.GE1651@lahna.fi.intel.com> (raw)
In-Reply-To: <1400136256-2218-11-git-send-email-rui.zhang@intel.com>

On Thu, May 15, 2014 at 02:44:15PM +0800, Zhang Rui wrote:
> +static void acpi_do_default_enumeration(struct acpi_device *device)
> +{
> +	/*
> +	 * Do not do enumeration for device object that has been/will be
> +	 * enumerated by its parent.
> +	 */
> +	if (device->parent && device->parent->flags.is_master_device)
> +		return;
> +
> +	/* Do not do enumeration for device object with scan handler attached */
> +	if (device->handler)
> +		return;
> +
> +	/* Do not do enumeration for device object w/o platform_id */
> +	if (!device->pnp.type.platform_id)
> +		return;
> +
> +	acpi_create_platform_device(device, NULL);
> +}
> +
> +

You have an extra empty line here.

  reply	other threads:[~2014-05-22  9:58 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-15  6:44 [PATCH V6 00/11] ACPI: ACPI enumeration rework Zhang Rui
2014-05-15  6:44 ` [PATCH V6 01/11] ACPI: introduce .match() callback for ACPI scan handler Zhang Rui
2014-05-15  6:44 ` [PATCH V6 02/11] PNPACPI: use whilte list for pnpacpi device enumeration Zhang Rui
2014-05-15  6:44 ` [PATCH V6 03/11] ACPI: remove ids that does not comply with the ACPI PNP id rule Zhang Rui
2014-05-15  6:44 ` [PATCH V6 04/11] ACPI: remove unsupported serial PNP ids from acpi pnp scan handler id lsit Zhang Rui
2014-05-15  6:44 ` [PATCH V6 05/11] ACPI: introduce dummy container scan handler Zhang Rui
2014-05-15  6:44 ` [PATCH V6 06/11] ACPI: introduce dummy memory hotplug " Zhang Rui
2014-05-15  6:44 ` [PATCH V6 07/11] ACPI: introduce dummy lpss " Zhang Rui
2014-05-21  8:48   ` Mika Westerberg
2014-05-21 14:56     ` Zhang Rui
2014-05-22  9:57       ` Mika Westerberg
2014-05-15  6:44 ` [PATCH V6 08/11] ACPI: introduce platform_id flag Zhang Rui
2014-05-15  6:44 ` [PATCH V6 09/11] ACPI: introduce flag .is_master_device Zhang Rui
2014-05-21  8:52   ` Mika Westerberg
2014-05-21 11:10     ` Rafael J. Wysocki
2014-05-21 11:04       ` Mika Westerberg
2014-05-21 11:59         ` Rafael J. Wysocki
2014-05-21 15:09       ` Zhang Rui
2014-05-22  8:08         ` Mika Westerberg
2014-05-21 14:43     ` Zhang Rui
2014-05-22  8:51       ` Mika Westerberg
2014-05-22 14:26         ` Zhang Rui
2014-05-15  6:44 ` [PATCH V6 10/11] ACPI: use platform bus as the default bus for _HID enumeration Zhang Rui
2014-05-22  9:58   ` Mika Westerberg [this message]
2014-05-15  6:44 ` [PATCH V6 11/11] ACPI: introduce acpi platform exclude id list Zhang Rui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140522095823.GE1651@lahna.fi.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=bhelgaas@google.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.garrett@nebula.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).