From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753010AbaE0RdU (ORCPT ); Tue, 27 May 2014 13:33:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7772 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751031AbaE0RdT (ORCPT ); Tue, 27 May 2014 13:33:19 -0400 Date: Tue, 27 May 2014 13:33:06 -0400 From: Mike Snitzer To: Mikulas Patocka Cc: Jens Axboe , Kent Overstreet , linux-kernel@vger.kernel.org, dm-devel@redhat.com, "Alasdair G. Kergon" Subject: Re: block: flush queued bios when the process blocks Message-ID: <20140527173306.GA12201@redhat.com> References: <5384AA79.4010206@kernel.dk> <5384B26D.1000703@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 27 2014 at 12:26pm -0400, Mikulas Patocka wrote: > On Tue, 27 May 2014, Jens Axboe wrote: > > > On 2014-05-27 09:23, Mikulas Patocka wrote: > > > > > The patch adds bio list flushing to the scheduler just besides plug > > > flushsing. > > > > ... which is exactly why I'm commenting. It'd be great to avoid yet one more > > scheduler hook for this sort of thing. > > > > -- > > Jens Axboe > > One could create something like schedule notifier chain, but I'm not sure > if it is worth the complexity because of just two users. If more users > come in the future, it could be generalized. It could be that Jens is suggesting updating blk_needs_flush_plug() and blk_schedule_flush_plug() to be bio_list aware too (rather than train sched_submit_work() from this new bio_list)? Somewhat awkward, but _could_ be made to work.